chore: Deprecate document of askUser
#575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdneo
reviewed
Dec 22, 2021
package.json
Outdated
| "%configuration.java.project.exportJar.targetPath.workspaceFolder%", | ||
| "%configuration.java.project.exportJar.targetPath.askUser%", | ||
| "%configuration.java.project.exportJar.targetPath.askUser%" | ||
| "%configuration.java.project.exportJar.targetPath.workspaceFolder%" |
There was a problem hiding this comment.
Add a description for "" as well?
There was a problem hiding this comment.
OK, added the description in f1a42c2
|
One more question, where can I see the description for the enums?
|
when you're editing this setting in raw settings.json
|
jdneo
reviewed
Dec 22, 2021
| @@ -28,11 +28,11 @@ | |||
| "configuration.java.dependency.packagePresentation": "Package presentation mode: flat or hierarchical", | |||
| "configuration.java.project.exportJar.targetPath": "Specifies the output path of export jar. The default value is `${workspaceFolder}/${workspaceFolderBasename}.jar`. You can leave it empty to select the output location manually each time exporting the jar file.", | |||
| "configuration.java.project.exportJar.targetPath.workspaceFolder": "Export the jar file into the workspace folder. Its name is the same as the folder's.", | |||
| "configuration.java.project.exportJar.targetPath.select": "You will select the output location manually each time exporting the jar file.", | |||
| "configuration.java.project.exportJar.targetPath.select": "Select output location manually when exporting the jar file.", | |||
There was a problem hiding this comment.
how about:
"configuration.java.project.exportJar.targetPath.customization": "The output path of the exported jar. Leave it to empty if you want to manually pick the output location."
There was a problem hiding this comment.
My bad. It should be leave it empty instead of leave it to empty
jdneo
approved these changes
Jan 18, 2022
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we now deprecate the documentation of
askUserfrom configurationjava.project.exportJar.targetPath, and the next step will be removing it totally.