Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support toggling awt development in help center #886

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Support toggling awt development in help center #886

merged 2 commits into from
Jan 18, 2022

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Jan 18, 2022

This PR adds a new entry to toggle the awt development in the Student section of Help Center.

Signed-off-by: sheche sheche@microsoft.com

Signed-off-by: sheche <sheche@microsoft.com>
@jdneo jdneo added this to the January 2022 milestone Jan 18, 2022
@jdneo jdneo requested a review from Eskibear January 18, 2022 03:12
Eskibear
Eskibear previously approved these changes Jan 18, 2022
Copy link
Member

@Eskibear Eskibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just wondering if we can simply add the entry in private groups, e.g. make it a getter, and the args value depends on this.props.isAwtDisabled. But I'm not sure if that would cause refresh of the whole page after you click the action.

Signed-off-by: sheche <sheche@microsoft.com>
@jdneo
Copy link
Member Author

jdneo commented Jan 18, 2022

LGTM.

Just wondering if we can simply add the entry in private groups, e.g. make it a getter, and the args value depends on this.props.isAwtDisabled. But I'm not sure if that would cause refresh of the whole page after you click the action.

Good idea! This simplified the code and won't refresh the whole page

@jdneo jdneo merged commit 414bf9c into main Jan 18, 2022
@jdneo jdneo deleted the cs/awt branch January 18, 2022 06:57
@jdneo jdneo mentioned this pull request Jan 24, 2022
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants