Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get ASTNode from ASTProvider #1052

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Get ASTNode from ASTProvider #1052

merged 2 commits into from
Aug 31, 2020

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Aug 31, 2020

Did some profiling to check the improvement. Given a 5000+ lines test file, doing the following operations:

  • 5 times of code completion (keep enter . and backspace)
  • write String a = "";
  • write String b = a;
  • insert code snippet systrace.

Before

WeChat Screenshot_20200831144332

After

WeChat Screenshot_20200831143822

@jdneo jdneo added this to the 0.25.0 milestone Aug 31, 2020
testforstephen
testforstephen reviewed Aug 31, 2020
View reviewed changes
...soft.java.test.plugin/src/main/java/com/microsoft/java/test/plugin/util/TestSearchUtils.java
parser.setResolveBindings(true);
parser.setIgnoreMethodBodies(true);
return parser.createAST(monitor);
final CompilationUnit astRoot = CoreASTProvider.getInstance().getAST(unit, CoreASTProvider.WAIT_YES, monitor);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any difference if setting to WAIT_NO?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check and not very significant difference observed

@jdneo jdneo merged commit 3e8af8f into master Aug 31, 2020
@jdneo jdneo deleted the cs/astProvider branch August 31, 2020 09:37
@jdneo jdneo mentioned this pull request Mar 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testforstephen testforstephen testforstephen approved these changes

@Eskibear Eskibear Awaiting requested review from Eskibear

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.24.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jdneo @testforstephen