Add support to specify java executable to use for test #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gayanper
force-pushed
the
add-java-path
branch
from
1bb32d5 to
3ce74e9
Compare
gayanper
force-pushed
the
add-java-path
branch
from
3ce74e9 to
9ce6247
Compare
jdneo
reviewed
Sep 4, 2023
|
Yes, this change was initiated for a scenario where I wanted to run some JDT debug tests with java21. This merge logic helps to resolve that. To be safe, i only merge keys which are not present in the config that passed in from PDE, but if we see a need we can extend to concat and merge existing attributes such as strings and arrays. |
|
Ok, makes sense. |
Signed-off-by: Sheng Chen <sheche@microsoft.com>
|
Thank you @gayanper for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying a different JRE (by providing the java executable) to be used for running the test. This helps when some tests needs to be executed against a different java version to