Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update target platform #1614

Closed
wants to merge 1 commit into from
Closed

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Sep 25, 2023

fix #1613

This will bump the embedded JUnit 5 to 5.10.0.

Signed-off-by: Sheng Chen <sheche@microsoft.com>
@jdneo
Copy link
Member Author

jdneo commented Sep 25, 2023

@dbalek

vscode-java-test-0.40.2023092502.vsix.zip

Using this private build and the latest Pre-release of the vscode-gradle extension, which uses the build server approach should solve the problem. I tested it locally on my machine and it works.

As it is mentioned in #1608, bump to JUnit 5.10.0 might cause the projects using <= 5.9.x failed to run the tests. I'm not planning to do that at this moment.

From your side, is there any kind of due date or something that need the VS Code Java side to address this issue ASAP? If yes, please let me know.

@dbalek
Copy link

dbalek commented Sep 26, 2023

Unfortunatly, tested with the attached vscode-java-test extension and the pre-release (v3.12.2023091801) of the vscode-gradle extension I am still getting the same error as in #1613

@jdneo
Copy link
Member Author

jdneo commented Sep 26, 2023

Sorry forget to mention, you need to clean the workspace cache.

  • Open the command palette (Press F1)
  • Select Java: Clean Java Language Server Workspace > Reload and delete

@dbalek
Copy link

dbalek commented Sep 26, 2023

Cleaning the workspace cache, still the same result

@jdneo
Copy link
Member Author

jdneo commented Sep 27, 2023

Could you share your VS Code settings? And maybe a screenshot of the Java Projects View (F1 >View: Focus on Java Projects View)

Another difference is that I'm using Micronaut 4.1.2 instead of 4.1.1

@dbalek
Copy link

dbalek commented Sep 27, 2023

I have started VSCode with the fresh --user-data-dir and --extensions-dir, and I have created the new Micronaut 4.1.2 project. So, the settings.json is almost empty now:

{
    "workbench.startupEditor": "none"
}

Still the same result:
screenshot-vscode

@jdneo
Copy link
Member Author

jdneo commented Sep 27, 2023

There is a node named Project and External Dependencies in the Java Projects View, which is a hint that the Gradle project is still imported by the old Gradle importer.

Could you try to clean Java Language Server Workspace again?

More details, see: redhat-developer/vscode-java#3260 (comment). Sorry for the confusion here.

@dbalek
Copy link

dbalek commented Sep 27, 2023

The node is named Referenced Libraries (Read-only) now, otherwise no change...

@jdneo
Copy link
Member Author

jdneo commented Sep 27, 2023

Still failed to launch tests?

@dbalek
Copy link

dbalek commented Sep 27, 2023

Yes, exactly the same error.

@jdneo
Copy link
Member Author

jdneo commented Sep 28, 2023

I can reproduce it now on MacOS. Previously I was using Windows, which works fine.

@yanisderbikov
Copy link

Is still open? Do you need help?

@jdneo
Copy link
Member Author

jdneo commented Nov 15, 2023

Thank you @yanisderbikov. Since bumping to JUnit 5.10.0 might cause the projects using <= 5.9.x failed to run the tests. I'm not planning to do that at this moment.

@jdneo
Copy link
Member Author

jdneo commented Mar 20, 2024

More and more users are migrating to 5.10.x

The estimate time for updating the target platform will happen in May.

@jdneo
Copy link
Member Author

jdneo commented Aug 7, 2024

Fixed in #1722

@jdneo jdneo closed this Aug 7, 2024
@jdneo jdneo deleted the cs/update-target-platform branch August 7, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Micronaut 4 Gradle project test execution broken
3 participants