refactor: Consume from the eclipse junit runner #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdneo
commented
Sep 5, 2019
src/runners/baseRunner/BaseRunner.ts
Outdated
| @@ -180,6 +182,25 @@ export abstract class BaseRunner implements ITestRunner { | |||
| return commandParams; | |||
| } | |||
|
|
|||
| protected getJavaEncoding(): string { | |||
There was a problem hiding this comment.
These two methods are just changed modifier from private to protected and changed the location up
Eskibear
reviewed
Sep 5, 2019
Eskibear
previously approved these changes
Sep 5, 2019
testforstephen
requested changes
Sep 5, 2019
src/runners/ITestRunner.ts
Outdated
| setup(tests: ITestItem[], isDebug: boolean, server: Server, config?: IExecutionConfig): Promise<void>; | ||
| run(): Promise<ITestResult[]>; | ||
| setup(tests: ITestItem[], isDebug: boolean, config?: IExecutionConfig, searchParam?: ISearchTestItemParams): Promise<DebugConfiguration>; | ||
| run(launchConfiguration: DebugConfiguration): Promise<ITestResult[]>; | ||
| cleanUp(isCancel: boolean): Promise<void>; |
src/runners/baseRunner/BaseRunner.ts
Outdated
| vmArgs: this.getVmArgs(config), | ||
| encoding: getJavaEncoding(Uri.parse(tests[0].location.uri), config), | ||
| env, | ||
| noDebug: !isDebug ? true : false, |
There was a problem hiding this comment.
no need of ternary expression. Use !isDebug directly.
jdneo
force-pushed
the
cs/junit4-runner
branch
from
5eec1c3 to
ff47d1d
Compare
testforstephen
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.