chore: adopt new terminal profile contribution point

Refs microsoft/vscode#120369

CHANGELOG.md

@@ -18,6 +18,7 @@ This changelog records changes to stable releases since 1.50.2. "TBA" changes he
 - feat: allow limited adjustment of launch config options during restart ([ref](https://github.com/microsoft/vscode/issues/118196))
 - fix: worker processes breaking sessions when attaching multiple times ([ref](https://github.com/microsoft/vscode/issues/124045))
 - fix: wrong name of autogenerated edge debug config
+- chore: adopt new terminal profile contribution point ([ref](https://github.com/microsoft/vscode/issues/120369))
 
 ## v1.56 (April 2021)
 

package.json

@@ -175,7 +175,8 @@
     "onDebugInitialConfigurations",
     "onDebugResolve:node",
     "onDebugResolve:extensionHost",
-    "onDebugResolve:chrome"
+    "onDebugResolve:chrome",
+    "onTerminalProfile:extension.js-debug.debugTerminal"
   ],
   "extensionKind": [
     "workspace"
@@ -203,9 +204,9 @@
       }
     ],
     "terminal": {
-      "types": [
+      "profiles": [
         {
-          "command": "extension.js-debug.createDebuggerTerminal",
+          "id": "extension.js-debug.debugTerminal",
           "title": "%debug.terminal.label%",
           "icon": "$(debug)"
         }

src/targets/node/terminalNodeLauncher.ts

@@ -129,9 +129,11 @@ export class TerminalNodeLauncher extends NodeLauncherBase<ITerminalLaunchConfig
       fileCallback: this.callbackFile,
     });
 
-    const terminal = vscode.window.createTerminal({
+    const terminal = await this.createTerminal({
       name: runData.params.name,
       cwd: runData.params.cwd,
+      // todo: add icon once https://github.com/microsoft/vscode/issues/125137 is fixed
+      // iconPath: new vscode.ThemeIcon("debug"),
       env: hideDebugInfoFromConsole(binary, env).defined(),
     });
     this.terminalCreatedEmitter.fire(terminal);
@@ -150,6 +152,13 @@ export class TerminalNodeLauncher extends NodeLauncherBase<ITerminalLaunchConfig
     });
   }
 
+  /**
+   * Creates a terminal with the requested options.
+   */
+  protected createTerminal(options: vscode.TerminalOptions) {
+    return Promise.resolve(vscode.window.createTerminal(options));
+  }
+
   /**
    * @inheritdoc
    */

src/test/test.ts

@@ -359,6 +359,7 @@ export class TestRoot {
         isVsCode: true,
         context: upcastPartial<ExtensionContext>({
           workspaceState: {
+            keys: [],
             get<T>(key: string, defaultValue?: T) {
               return workspaceState.get(key) ?? defaultValue;
             },