feat: adopt isTransient to avoid persisting debug terminal

Fixes #1196
microsoft · Feb 9, 2022 · 78aedd4 · 78aedd4
1 parent a21d6b6
commit 78aedd4
Show file tree

Hide file tree

Showing 7 changed files with 566 additions and 106 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@ This changelog records changes to stable releases since 1.50.2. "TBA" changes he
 
 ## Nightly Only
 
+- feat: adopt `isTransient` to avoid persisting debug terminal ([#1196](https://github.com/microsoft/vscode-js-debug/issues/1196))
 - fix: don't use `pwa-` prefixed launch types in snuppets ([#1138](https://github.com/microsoft/vscode-js-debug/issues/1138))
 - fix: logpoints causing pauses if console.log returns truthy ([#1191](https://github.com/microsoft/vscode-js-debug/issues/1191))
 - fix: handle query string and path fragments in `file`s within the launch config ([vscode#142199](https://github.com/microsoft/vscode/issues/142199))

diff --git a/package.json b/package.json
@@ -16,7 +16,7 @@
   "description": "An extension for debugging Node.js programs and Chrome.",
   "license": "MIT",
   "engines": {
-    "vscode": "^1.60.0-insider",
+    "vscode": "^1.64.0",
     "node": ">=10"
   },
   "icon": "resources/logo.png",

diff --git a/src/targets/node/terminalNodeLauncher.ts b/src/targets/node/terminalNodeLauncher.ts
@@ -134,6 +134,7 @@ export class TerminalNodeLauncher extends NodeLauncherBase<ITerminalLaunchConfig
       cwd: runData.params.cwd,
       iconPath: new vscode.ThemeIcon('debug'),
       env: hideDebugInfoFromConsole(binary, env).defined(),
+      isTransient: true,
     });
     this.terminalCreatedEmitter.fire(terminal);