fix: process attachment with --inspect=:1234 style (#2064)

Fixes #2063
microsoft · Aug 30, 2024 · 9084de6 · 9084de6
1 parent 105ccb4
commit 9084de6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,7 +4,7 @@ This changelog records changes to stable releases since 1.50.2. "TBA" changes he
 
 ## Nightly (only)
 
-Nothing, yet
+- fix: process attachment with `--inspect=:1234` style ([#2063](https://github.com/microsoft/vscode-js-debug/issues/2063))
 
 ## v1.93 (August 2024)
 

diff --git a/src/ui/processTree/processTree.test.ts b/src/ui/processTree/processTree.test.ts
@@ -9,6 +9,7 @@ describe('process tree', () => {
   describe('analyze arguments', () => {
     const tt = [
       { input: 'node --inspect', address: '127.0.0.1', port: 9229 },
+      { input: 'node --inspect=:1234', address: '127.0.0.1', port: 1234 },
       { input: 'node --inspect=0.0.0.0', address: '0.0.0.0', port: 9229 },
       { input: 'node --inspect=0.0.0.0:1234', address: '0.0.0.0', port: 1234 },
       { input: 'node --inspect=[::1]:1234', address: '[::1]', port: 1234 },

diff --git a/src/ui/processTree/processTree.ts b/src/ui/processTree/processTree.ts
@@ -89,7 +89,12 @@ const DEBUG_FLAGS_PATTERN = once(() => {
       '|',
 
       // Simple port:
-      '(?<port2>\\d+)?',
+      [
+        '(?:',
+        ':?', // optional ':' before port, #2063
+        '(?<port2>\\d+)?',
+        ')',
+      ],
 
       ')',
     ],