fix: source map warning on node 15

Fixes #903

CHANGELOG.md

@@ -17,6 +17,7 @@ This changelog records changes to stable releases since 1.50.2. "TBA" changes he
 - fix: fix: better handle html served as index and without extensions ([#883](https://github.com/microsoft/vscode-js-debug/issues/883), [#884](https://github.com/microsoft/vscode-js-debug/issues/884))
 - docs: remove preview terminology from js-debug ([#894](https://github.com/microsoft/vscode-js-debug/issues/894))
 - fix: debugger statements being missed if directly stepped on the first executable line of a new script early in execution
+- fix: source map warning on node 15 ([#903](https://github.com/microsoft/vscode-js-debug/issues/903))
 
 ## v1.52.2 - 2020-12-07
 

src/adapter/scriptSkipper/implementation.ts

@@ -9,6 +9,7 @@ import { ICdpApi } from '../../cdp/connection';
 import { MapUsingProjection } from '../../common/datastructure/mapUsingProjection';
 import { EventEmitter } from '../../common/events';
 import { ILogger, LogTag } from '../../common/logging';
+import { node15InternalsPrefix } from '../../common/node15Internal';
 import { trailingEdgeThrottle } from '../../common/objUtils';
 import * as pathUtils from '../../common/pathUtils';
 import { getDeferred, IDeferred } from '../../common/promiseUtil';
@@ -32,8 +33,6 @@ interface ISharedSkipToggleEvent {
   params: Dap.ToggleSkipFileStatusParams;
 }
 
-const node15InternalsPrefix = 'node:';
-
 @injectable()
 export class ScriptSkipper {
   private static sharedSkipsEmitter = new EventEmitter<ISharedSkipToggleEvent>();

src/adapter/sources.ts

@@ -1104,7 +1104,7 @@ export class SourceContainer {
 
     const sourceMap = this._sourceMaps.get(source.sourceMap.url);
     if (
-      !this.logger.assert(sourceMap, 'Unrecognized source mpa url in waitForSourceMapSources()')
+      !this.logger.assert(sourceMap, 'Unrecognized source map url in waitForSourceMapSources()')
     ) {
       return [];
     }

src/adapter/threads.ts

@@ -1123,7 +1123,7 @@ export class Thread implements IVariableStoreDelegate {
         // but in practice that usually means new scripts with new source maps anyway.
         resolvedSourceMapUrl = urlUtils.isDataUri(event.sourceMapURL)
           ? event.sourceMapURL
-          : event.url && urlUtils.completeUrl(event.url, event.sourceMapURL);
+          : (event.url && urlUtils.completeUrl(event.url, event.sourceMapURL)) || event.url;
         if (!resolvedSourceMapUrl) {
           this._dap.with(dap =>
             errors.reportToConsole(dap, `Could not load source map from ${event.sourceMapURL}`),

src/common/node15Internal.ts

@@ -0,0 +1,8 @@
+/*---------------------------------------------------------
+ * Copyright (C) Microsoft Corporation. All rights reserved.
+ *--------------------------------------------------------*/
+
+/**
+ * URL prefix that Node 15 and onwards uses for its internals.
+ */
+export const node15InternalsPrefix = 'node:';

src/targets/sourcePathResolver.ts

@@ -5,6 +5,7 @@
 import match from 'micromatch';
 import * as path from 'path';
 import { ILogger, LogTag } from '../common/logging';
+import { node15InternalsPrefix } from '../common/node15Internal';
 import {
   fixDriveLetter,
   fixDriveLetterAndSlashes,
@@ -71,6 +72,12 @@ export abstract class SourcePathResolverBase<T extends ISourcePathResolverOption
    * following the `resolveSourceMapPaths`
    */
   public shouldResolveSourceMap({ sourceMapUrl, compiledPath }: ISourceMapMetadata) {
+    // Node 15 started including some source-mapped internals (acorn), but
+    // they don't ship source maps in the build. Never try to resolve those.
+    if (compiledPath.startsWith(node15InternalsPrefix)) {
+      return false;
+    }
+
     if (!this.resolveLocations || this.resolveLocations.length === 0) {
       return true;
     }