Skip to content

Commit

Permalink
fix: debug targets orphaned when a detached child starts after a pare…
Browse files Browse the repository at this point in the history
…nt exits

Fixes microsoft/vscode#219673
  • Loading branch information
connor4312 committed Jul 3, 2024
1 parent b2a955a commit e047d17
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ This changelog records changes to stable releases since 1.50.2. "TBA" changes he
## Nightly (only)

- fix: breakpoints at unmapped locations setting in wrong locations ([vscode#219031](https://github.com/microsoft/vscode/issues/219031))
- fix: debug targets orphaned when a detached child starts after a parent exits ([vscode#219673](https://github.com/microsoft/vscode/issues/219673))

## v1.91 (June 2024)

Expand Down
6 changes: 3 additions & 3 deletions src/ui/debugTerminalUI.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,19 +94,19 @@ export const launchVirtualTerminalParent = (
// Skip targets the consumer asked to filter out.
if (!filterTarget(target)) {
target.detach();
return;
continue;
}

// Check that we didn't detach from the parent session.
if (target.targetInfo.openerId && !target.parent()) {
target.detach();
return;
continue;
}

// Detach from targets if workspace trust was not granted
if (!trusted) {
target.detach();
return;
continue;
}

if (!target.parent()) {
Expand Down

0 comments on commit e047d17

Please sign in to comment.