Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger pwa-chrome configuration does not stop on breakpoints #1225

Closed
izkrivera opened this issue Mar 22, 2022 · 9 comments · Fixed by #1253
Closed

Debugger pwa-chrome configuration does not stop on breakpoints #1225

izkrivera opened this issue Mar 22, 2022 · 9 comments · Fixed by #1253
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@izkrivera
Copy link

Describe the bug

When running the JS Debugger (nightly v2022.3.717) breakpoints are always off (empty dots). Toggling then on the breakpoints panel turns some of them on (red). However, the breakpoints never pause execution.

Configuration on a Next's / typescript running on the localhost:

"configurations": [
        {
            "name": "Chrome localhost",
            "type": "pwa-chrome",
            "request": "launch",
            "url": "http://app.XXXXXXXX.local:3000",
        }
    ]

To Reproduce
Steps to reproduce the behavior:

  1. Add breakpoints to any .tsx file
  2. Click on 'Start Debugging'
  3. Navigate to where the breakpoint should fire
  4. Confirm it does not fire

Log File
vscode-debugadapter-25a5d31c.json.gz

VS Code Version: 1.65.2

Additional context
Next's and Typescript, localhost app.

@izkrivera izkrivera added the bug Issue identified by VS Code Team member as probable bug label Mar 22, 2022
@connor4312 connor4312 added this to the May 2022 milestone May 4, 2022
@connor4312
Copy link
Member

This'll be fixed in the upcoming nightly build. Please give it a shot!

@trinoorrod
Copy link

In latest VSCode build, this is broken again.
Previously was not broken, applied update today and now I cannot set breakpoints.
{
"name": "DESKTOP: Attach to Chrome",
"port": 9222,
"request": "attach",
"type": "pwa-chrome",
"webRoot": "${workspaceFolder}",
}

@trinoorrod
Copy link

Just to add: rolling back to VSCode March 2022 (1.66.2), breakpoints function as normal.

@connor4312
Copy link
Member

Sorry, this PR didn't get merged yet. Will ping for reviews on it tomorrow.

@trinoorrod
Copy link

No worries. FWIW, on MacOS between VSCode 1.66.2 and 1.67 debug broke.
We've rolled back to 1.66.2, so no biggie right now.
Will try the nightly to see if your fix has resolved whatever issue we're having and let you know.

@connor4312
Copy link
Member

connor4312 commented May 9, 2022

You're probably not facing the same issue as the poster as this bug was present and reported on 1.66.

@trinoorrod
Copy link

It's definitely the same bug, we've also seen it before. It seems to be one of those issue where fixing it for one case breaks it for others.
However, can confirm js-debug-nightly resolves the issue for us.

@connor4312
Copy link
Member

connor4312 commented May 9, 2022

If nightly resolves it you're probably hitting microsoft/vscode#148864

connor4312 added a commit that referenced this issue May 10, 2022
* fix: remove query strings from sourcemapped URLs

Fixes #1225
Fixes microsoft/vscode#147662

* chore: update windows vm image
connor4312 added a commit that referenced this issue May 17, 2022
* fix: remove query strings from sourcemapped URLs

Fixes #1225
Fixes microsoft/vscode#147662

* chore: update windows vm image
@roblourens roblourens added the author-verification-requested Issues potentially verifiable by issue author label Jun 3, 2022
@TylerLeonhardt
Copy link
Member

@izkrivera Can you try out the latest insider build of VS Code: http://code.visualstudio.com/insiders if the issue is fixed there, can you please respond with /verified so we can mark this issue as verified to be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants