Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for console.profile / console.profileEnd #1443

Closed
connor4312 opened this issue Nov 12, 2022 · 0 comments · Fixed by #1444
Closed

Add support for console.profile / console.profileEnd #1443

connor4312 opened this issue Nov 12, 2022 · 0 comments · Fixed by #1444
Assignees
@connor4312
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2022

Comments

@connor4312
Copy link
Member

V8 has APIs for console.profile that allow the application to collect a profile. We should respect that in js-debug, automatically saving the profile if one is created from these APIs.
@connor4312 connor4312 added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Nov 12, 2022
@connor4312 connor4312 added this to the November 2022 milestone Nov 12, 2022
@connor4312 connor4312 self-assigned this Nov 12, 2022
connor4312 added a commit that referenced this issue Nov 12, 2022
@connor4312
feat: support console.profile
055f5a5 
Fixes #1443

By default, the profile is saved (using a date-stamped name) in the workspace
folder. If the user gives the profile a name by passing an argument to
`console.profile`, then that is appended with .consolprofie and used instead.
@connor4312 connor4312 mentioned this issue Nov 12, 2022
Merged
@chrisdias chrisdias mentioned this issue Nov 14, 2022
Closed
@lramos15 lramos15 added the verified Verification succeeded label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

feat: support console.profile microsoft/vscode-js-debug
2 participants
@connor4312 @lramos15