-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS code crashes when debugging after update with Node <=12 #1624
Comments
Can you grab a recording/gif of your vscode window? https://gifcap.dev/ is helpful |
Thanks, looks like that's an issue on very old Node.js versions. I will put in a patch for this, but I also strongly recommend upgrading as your version of Node.js has been end of life for about two years now and no longer receives security updates. |
@connor4312 Thanks for looking into this. I plan on updating NodeJS later. I have some dependency issues to work out first. Is there a way I can track the progress of the patch? |
I'll put a fix in for this today. When the issue is closed, it'll be fixed in sources. You can expect it to appear in the nightly build shortly after 5PM PST the same day. |
Refs microsoft/vscode-js-debug#1624 I noticed that issue was being called by new syntax being used in the bootloader that Node 12 didn't understand. But localizations shouldn't be in the bootloader at all, and with this change, it enables @vscode/l10n to be tree shaken out. Separate issue is why our test suites that nominally run Node 8 didn't pick up on this earlier...
* fix: mark @vscode/l10n as side-effect-free Refs microsoft/vscode-js-debug#1624 I noticed that issue was being called by new syntax being used in the bootloader that Node 12 didn't understand. But localizations shouldn't be in the bootloader at all, and with this change, it enables @vscode/l10n to be tree shaken out. Separate issue is why our test suites that nominally run Node 8 didn't pick up on this earlier... * rev to 0.0.13
Fixes #1624 Updates @vscode/l10n to allow it to be tree-shaken away. Also moves `checkContentHash` that likewise had a dependency on more modern language features. I think webpack was just extra aggressive about tree shaking before and assumed `new Hasher()` was side effect free. Which is was, it's just a big assumption to have made. And when I had updated versions in our pipelines, I accidentally updated the minspec to no longer target Node 8 🤦♂️. Targeting the latest 10 should be good. Node 8 thankfully <0.25% of users nowadays.
Fixes #1624 Updates @vscode/l10n to allow it to be tree-shaken away. Also moves `checkContentHash` that likewise had a dependency on more modern language features. I think webpack was just extra aggressive about tree shaking before and assumed `new Hasher()` was side effect free. Which is was, it's just a big assumption to have made. And when I had updated versions in our pipelines, I accidentally updated the minspec to no longer target Node 8 🤦♂️. Targeting the latest 10 should be good. Node 8 thankfully <0.25% of users nowadays.
* fix: sourcemap lookups on ipv6 localhost addresses TIL that assigning an invalid value to `url.hostname` silently fails if invalid. Fixes microsoft/vscode#167353 * fix: debugger failing on Node <=12 Fixes #1624 Updates @vscode/l10n to allow it to be tree-shaken away. Also moves `checkContentHash` that likewise had a dependency on more modern language features. I think webpack was just extra aggressive about tree shaking before and assumed `new Hasher()` was side effect free. Which is was, it's just a big assumption to have made. And when I had updated versions in our pipelines, I accidentally updated the minspec to no longer target Node 8 🤦♂️. Targeting the latest 10 should be good. Node 8 thankfully <0.25% of users nowadays. * keep broken minspec for the moment
* fix: sourcemap lookups on ipv6 localhost addresses TIL that assigning an invalid value to `url.hostname` silently fails if invalid. Fixes microsoft/vscode#167353 * fix: debugger failing on Node <=12 Fixes #1624 Updates @vscode/l10n to allow it to be tree-shaken away. Also moves `checkContentHash` that likewise had a dependency on more modern language features. I think webpack was just extra aggressive about tree shaking before and assumed `new Hasher()` was side effect free. Which is was, it's just a big assumption to have made. And when I had updated versions in our pipelines, I accidentally updated the minspec to no longer target Node 8 🤦♂️. Targeting the latest 10 should be good. Node 8 thankfully <0.25% of users nowadays. * keep broken minspec for the moment
This is now fixed in the nightly build. I will also propose it for a recovery release next week. |
Still not working, but now without crashing and errors |
It just freezes
|
Thanks for letting me know, it looks like esbuild by default can change syntax during its minification process, which I didn't catch when developing the (unminified) extension locally. New build incoming in a little while. |
Related questions on Stack Overflow: |
@connor4312 how do I get the fix? I need to wait for a future VS Code release next week? |
Verified and it started the debugger successfully
|
Describe the bug
After VS code updated to 1.77.0 I can no longer debug my NodeJS application.
To Reproduce
Click the debug button
Launch.json
Debug Console
Log File
vscode-debugadapter-c0d5382f.json.gz
VS Code Version:
Version: 1.77.0 (user setup)
Commit: 7f329fe6c66b0f86ae1574c2911b681ad5a45d63
Date: 2023-03-29T10:02:16.981Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: No
Additional context
The text was updated successfully, but these errors were encountered: