Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Object Property Value Shorthand in Logpoints for JS #1788

Closed
Stan-Stani opened this issue Aug 21, 2023 · 3 comments · Fixed by #1935
Closed

Support Object Property Value Shorthand in Logpoints for JS #1788

Stan-Stani opened this issue Aug 21, 2023 · 3 comments · Fixed by #1935
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@Stan-Stani
Copy link

Stan-Stani commented Aug 21, 2023 •
edited
Loading

Support object shorthand definition, e.g.

The more detailed debug output is the result of:
console.log({person})
but the undefined output is using logpoint:
{{person}}
image
@roblourens
Copy link
Member

What exactly did you write in the logpoint?

@roblourens roblourens added the info-needed Issue requires more information from poster label Aug 23, 2023
@Stan-Stani
Copy link
Author

{{person}}

@roblourens
Copy link
Member

This works if I wrap the expression in () like {({person})}, so I think maybe js-debug just doesn't parse {{person}} correctly

@roblourens roblourens assigned connor4312 and unassigned roblourens Aug 23, 2023
@connor4312 connor4312 transferred this issue from microsoft/vscode Aug 24, 2023
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Aug 24, 2023
connor4312 added a commit that referenced this issue Jan 31, 2024
@connor4312
fix: support object property shorthand in logpoints
1c683f5 
Fixes #1788
@connor4312 connor4312 mentioned this issue Jan 31, 2024
Merged
connor4312 added a commit that referenced this issue Jan 31, 2024
@connor4312
fix: support object property shorthand in logpoints (#1935)
5f87aa0 
Fixes #1788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support object property shorthand in logpoints microsoft/vscode-js-debug
3 participants
@roblourens @connor4312 @Stan-Stani