feat: Tidying Up of Instrumentation Breakpoints #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
connor4312
reviewed
Oct 17, 2023
src/ui/customBreakpointsUI.ts
Outdated
| }), | ||
| ); | ||
|
|
||
| context.subscriptions.push( | ||
| vscode.commands.registerCommand(Commands.RemoveAllCustomBreakpoints, () => { | ||
| provider.removeBreakpoints(provider.breakpoints.filter(b => b.enabled).map(b => b.id)); | ||
| provider.removeBreakpoints( | ||
| provider.breakpointCategories |
There was a problem hiding this comment.
Wouldn't this only remove categories that have all of their children checked, and not individual children?
OnesAndZer0s
changed the title
|
Can we put XHR breakpoints into a separate PR to keep this one focused on the existing changes? |
OnesAndZer0s
changed the title
|
connor4312
reviewed
Oct 19, 2023
connor4312
approved these changes
Oct 23, 2023
lramos15
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Browser Breakpoints", renamed to "Event Listener Breakpoints", are now organized in a tree-view structure, utilizing the new Treeview-Checkbox API
