-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Addition of XHR/feat Breakpoints #1856
Conversation
OnesAndZer0s
commented
Oct 19, 2023
I wonder if we could fold this into the existing Event Listener Breakpoints view to avoid add more UI clutter. Spitballing:
|
c86f96a
to
3562af1
Compare
I agree, that sounds like a good idea. However, I have some qualms:
Otherwise, yeah that does sounds nice. |
Perhaps we call them "URL XHR Breakpoints"?
Indeed, ctrl+f for "If you want to show an action for specific tree items" on https://code.visualstudio.com/api/extension-guides/tree-view#view-actions |
It seems like the package-lock.json was rewritten, probably with a newer version of npm. Can you undo that change? We use Node 18 and its included version of npm in our pipelines. |
parent.checkboxState = state; | ||
} else if ( | ||
enabled && | ||
(this.getChildren(parent) as XHRBreakpoint[]).every( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add parent
and checked
on the XHRBreakpoint then we can avoid this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XHRBreakpoint
already has checked
. What would be avoiding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, a couple last comments
Fixed. Is there any other suggestions? |