Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "debug url" in terminals created through the node-terminal launch type #2049

Closed
WittonBell opened this issue Aug 2, 2024 · 1 comment · Fixed by #2050
Closed
Assignees

Comments

@WittonBell
Copy link

WittonBell commented Aug 2, 2024

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.92.0
  • OS Version: Win10 22H2

Steps to Reproduce:

  1. create a t directory
  2. open t with VSCode
  3. run npm init in terminal of VSCode, the package.json use following configure:
{
  "name": "t",
  "version": "1.0.0",
  "main": "index.js",
  "scripts": {
    "dev": "echo http://127.0.0.1:5173"
  }
}
  1. create .vscode/launch.json and add configuration with run "npm start" in a debug terminal

launch.json:

{
	"version": "0.2.0",
	"configurations": [
		{
			"command": "npm run dev",
			"name": "Run npm start",
			"request": "launch",
			"type": "node-terminal"
		}
	]
}
  1. Press F5 run Run npm start configuration
  2. move mouse on http://127.0.0.1:5173 in terminal output, hover show Follow link(crtl + click), but Debug URL(crtl + click) expected. Open JavaScript Debug Terminal, run npm run dev, http://127.0.0.1:5173 hover show Debug URL(crtl + click).

There doesn't seem to be a way to configure launcher.json and start debugging URL. Currently, the closest way is to configure with run "npm start" in a debug terminal, but it only follow the URL, not starts debugging mode. So it could be a bug.

Copy link

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.92.0. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@roblourens roblourens assigned connor4312 and unassigned roblourens Aug 2, 2024
@connor4312 connor4312 changed the title cannot start debug url when config with run "npm start" in a debug terminal in launch.json Support "debug url" in terminals created through the node-terminal launch type Aug 2, 2024
@connor4312 connor4312 transferred this issue from microsoft/vscode Aug 2, 2024
connor4312 added a commit that referenced this issue Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants