-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The less settings the better #732
Comments
On top of this there is a lot of settins overlap how autoAttach can be enabled / disabled. For example one of the options for |
Also "debug.node.autoAttach": "disabled" puts it to |
Absolutely right! The |
The preponderance of auto attach settings specifically is something brought up in standup as well.
This was existing functionality, cc @weinand. I wonder if we need a button at all once js-debug auto attach is implemented, since at that point auto attach will be fairly passive. Thoughts? |
The only reason why The "on" and "off" states exist because the old "auto attach" feature is based on polling which has a cost. |
Great, so it seems like we are all aligned. |
Refs: microsoft/vscode#105771
I noticed that we introduced quite some settings for debug.javascript while most of this make perfect sense I just wanted to share my thoughts that:
I did not really review all of them but there are some quite obscure ones, like for example
"debug.javascript.warnOnLongPrediction"
Just my 2 cents.
The text was updated successfully, but these errors were encountered: