Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using trace on multiple js targets in a compound configuration produces corrupt logs #825

Closed
nikitalita opened this issue Oct 29, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@nikitalita
Copy link

nikitalita commented Oct 29, 2020

Describe the bug
When using a compound configuration for debugging, vscode-js-debug will write trace logs to the same log file for all targets with trace enabled if they each use vscode-js-debug. This ends up producing corrupt logs.

You'd run into this in attempting to debug electron apps, where you would want to debug the main process and renderer process simultaneously.

To Reproduce
Steps to reproduce the behavior:
I've created a branch in my repo to reproduce this:

  1. git clone --branch new-debug https://github.com/nikitalita/steam-gyro-for-cemuhook
  2. npm i && npm run build:all-debug
  3. Open in VS Code, run debug for "Electron: All" (which should be the default).
  4. After the app has finished launching, stop it.
  5. Observe in the debug console where it wrote the log for each process (Electron:Main and Electron: Renderer). It should be the same file.
  6. Try and upload the resulting log to vscode-pwa-analyzer
  7. Analyzer throws an error decompressing.

Log File
image

Corrupt log file:
vscode-debugadapter-8.json.gz

VS Code Version: 1.50.1
image

@nikitalita nikitalita added the bug Issue identified by VS Code Team member as probable bug label Oct 29, 2020
@connor4312 connor4312 added this to the November 2020 milestone Oct 30, 2020
@connor4312
Copy link
Member

Thanks for the issue!

Verifiers: this can be reproduced fairly easily using any compound launch config which launches multiple configurations with trace: true

digeff pushed a commit that referenced this issue Nov 9, 2020
@roblourens roblourens added the verified Verification succeeded label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants