chore: make sourcePathResolver function per-thread #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Jul 28, 2019
src/adapter/sources.ts
Outdated
| @@ -90,7 +90,7 @@ export interface SourcePathResolver { | |||
| // | |||
| export class Source { | |||
| private static _lastSourceReference = 0; | |||
|
|
|||
| readonly sourcePathResolver: SourcePathResolver; | |||
There was a problem hiding this comment.
Why public? Seems to be only used in this file.
There was a problem hiding this comment.
I'll make it "[public] _sourcePathResolver" consistency, but I wonder if that's what we want to do long term!
| @@ -703,7 +703,7 @@ export class Thread implements VariableStoreDelegate { | |||
| } | |||
|
|
|||
| _onScriptParsed(event: Cdp.Debugger.ScriptParsedEvent) { | |||
| event.url = this.manager._sourcePathResolver.scriptUrlToUrl(event.url); | |||
| event.url = this.sourcePathResolver.scriptUrlToUrl(event.url); | |||
There was a problem hiding this comment.
Perhaps we don't want to dedupe scripts with different resolvers by url (see _getSourceForScript). Maybe that will never happen in practice though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.