fix: assorted bad source behaviors when reloading a page #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like esbuild doesn't deal with const enums in dependency .d.ts like ts does
connor4312
commented
Mar 3, 2023
| @@ -610,7 +609,7 @@ export class BreakpointManager { | |||
| await Promise.all( | |||
| result.unbound.map(b => { | |||
| this._byDapId.delete(b.dapId); | |||
| b.disable(); | |||
| return b.disable(); | |||
There was a problem hiding this comment.
this fixes a test flake that's failed like 1 in 200 runs for the past two years
joyceerhl
approved these changes
Mar 3, 2023
joyceerhl
approved these changes
Mar 3, 2023
|
Noice |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1582
We weren't dealing with removed execution contexts at all (e.g. removing an iframe or worker), only cleared ones (e.g. refreshing the entire page). Now, removing an execution context properly removes its sources, and scripts from multiple contexts are handled.
I think this is also an underlying fix for several other bugs I have open; will investigate tomorrow.