Using Ian's setting name instead. Changed wording

microsoft · May 25, 2022 · 52b0b24 · 52b0b24
1 parent 6278a40
commit 52b0b24
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -2001,10 +2001,10 @@
                     "description": "Add PYTHONNOUSERSITE to kernels before starting. This prevents global/user site-packages from being used in the PYTHONPATH of the kernel.",
                     "scope": "machine"
                 },
-                "jupyter.enablePreciseKernelCompletions": {
+                "jupyter.enableExtendedKernelCompletions": {
                     "type": "boolean",
                     "default": false,
-                    "description": "Enables the use of Jedi to generate more precise kernel completions. This can impact peformance, such as preventing executions from running. Use with caution.",
+                    "description": "Enables Jedi support for extended IntelliSense completions from running Jupyter kernels. This can greatly impact notebook cell execution performance. Use with caution.",
                     "scope": "machine"
                 }
             }

diff --git a/src/kernels/kernel.base.ts b/src/kernels/kernel.base.ts
@@ -623,7 +623,7 @@ export abstract class BaseKernel implements IKernel {
             if (file) {
                 result.push(`__vsc_ipynb_file__ = "${file.replace(/\\/g, '\\\\')}"`);
             }
-            if (!this.configService.getSettings(undefined).enablePreciseKernelCompletions) {
+            if (!this.configService.getSettings(undefined).enableExtendedKernelCompletions) {
                 result.push(CodeSnippets.DisableJedi);
             }
 

diff --git a/src/platform/common/configSettings.ts b/src/platform/common/configSettings.ts
@@ -101,7 +101,7 @@ export class JupyterSettings implements IWatchableJupyterSettings {
     public logKernelOutputSeparately: boolean = false;
     public poetryPath: string = '';
     public excludeUserSitePackages: boolean = false;
-    public enablePreciseKernelCompletions: boolean = false;
+    public enableExtendedKernelCompletions: boolean = false;
 
     public variableTooltipFields: IVariableTooltipFields = {
         python: {

diff --git a/src/platform/common/types.ts b/src/platform/common/types.ts
@@ -115,7 +115,7 @@ export interface IJupyterSettings {
     readonly logKernelOutputSeparately: boolean;
     readonly poetryPath: string;
     readonly excludeUserSitePackages: boolean;
-    readonly enablePreciseKernelCompletions: boolean;
+    readonly enableExtendedKernelCompletions: boolean;
 }
 
 export interface IVariableTooltipFields {

diff --git a/src/test/datascience/notebook/intellisense/completionProvider.vscode.test.ts b/src/test/datascience/notebook/intellisense/completionProvider.vscode.test.ts
@@ -64,8 +64,8 @@ import { Settings } from '../../../../platform/common/constants';
                 previousPythonCompletionTriggerCharactersValue = jupyterConfig.get<string>(
                     'pythonCompletionTriggerCharacters'
                 );
-                previousJediSetting = jupyterConfig.get<boolean>('enablePreciseKernelCompletions');
-                await jupyterConfig.update('enablePreciseKernelCompletions', useJedi, ConfigurationTarget.Global);
+                previousJediSetting = jupyterConfig.get<boolean>('enableExtendedKernelCompletions');
+                await jupyterConfig.update('enableExtendedKernelCompletions', useJedi, ConfigurationTarget.Global);
                 await jupyterConfig.update('pythonCompletionTriggerCharacters', '.%"\'', ConfigurationTarget.Global);
                 api = await initialize();
                 if (IS_REMOTE_NATIVE_TEST()) {
@@ -105,7 +105,7 @@ import { Settings } from '../../../../platform/common/constants';
                         ConfigurationTarget.Global
                     );
                 await jupyterConfig.update(
-                    'enablePreciseKernelCompletions',
+                    'enableExtendedKernelCompletions',
                     previousJediSetting,
                     ConfigurationTarget.Global
                 );