Eslint rule for platform (#10544)

* update for types

* move constants into platform

* eslint rule enforced for platform

.eslintrc.js

@@ -318,10 +318,6 @@ module.exports = {
                     {
                         target: './src/**[!test,standalone,webviews]**/**/*.ts',
                         from: './src/webviews/**/*.ts',
-                        except: [
-                            '**/src/webviews/webview-side/common/constants.ts',
-                            '**/src/webviews/types',
-                        ],
                         message: 'Importing modules from ./src/webviews into core components (platform, kernels, notebooks, interactive-window) is not allowed.'
                     },
                     {
@@ -332,7 +328,12 @@ module.exports = {
                     {
                         target: './src/telemetry/**/**[!types]**.ts',
                         from: './src/**[!telemetry,platform]**/**/*.ts',
-                        message: 'Importing non-platform modules into telemetry files is not allowed.'
+                        message: 'Importing non-telemetry modules into telemetry files is not allowed.'
+                    },
+                    {
+                        target: './src/platform/**/*.ts',
+                        from: './src/**[!platform]**/**/*.ts',
+                        message: 'Importing non-platform modules into platform files is not allowed.'
                     }
                 ]
             }

src/commands.ts

@@ -13,7 +13,7 @@ import {
     Uri,
     ViewColumn
 } from 'vscode';
-import { IShowDataViewerFromVariablePanel } from './platform/messageTypes';
+import { IShowDataViewerFromVariablePanel } from './messageTypes';
 import { Commands as DSCommands } from './platform/common/constants';
 import { PythonEnvironment } from './platform/pythonEnvironments/info';
 import { CommandSource } from './platform/testing/common/constants';

src/extension.node.ts

@@ -65,7 +65,6 @@ import { Common, OutputChannelNames } from './platform/common/utils/localize';
 import { IServiceContainer, IServiceManager } from './platform/ioc/types';
 import { sendErrorTelemetry, sendStartupTelemetry } from './platform/telemetry/startupTelemetry';
 import { noop } from './platform/common/utils/misc';
-import { PythonExtension } from './webviews/webview-side/common/constants';
 import { registerTypes as registerPlatformTypes } from './platform/serviceRegistry.node';
 import { registerTypes as registerKernelTypes } from './kernels/serviceRegistry.node';
 import { registerTypes as registerNotebookTypes } from './notebooks/serviceRegistry.node';
@@ -75,7 +74,13 @@ import { registerTypes as registerTelemetryTypes } from './platform/telemetry/se
 import { registerTypes as registerIntellisenseTypes } from './intellisense/serviceRegistry.node';
 import { registerTypes as registerWebviewTypes } from './webviews/extension-side/serviceRegistry.node';
 import { IExtensionActivationManager } from './platform/activation/types';
-import { isCI, isTestExecution, JUPYTER_OUTPUT_CHANNEL, STANDARD_OUTPUT_CHANNEL } from './platform/common/constants';
+import {
+    isCI,
+    isTestExecution,
+    JUPYTER_OUTPUT_CHANNEL,
+    PythonExtension,
+    STANDARD_OUTPUT_CHANNEL
+} from './platform/common/constants';
 import { getDisplayPath } from './platform/common/platform/fs-paths';
 import { IFileSystemNode } from './platform/common/platform/types.node';
 import { getJupyterOutputChannel } from './standalone/devTools/jupyterOutputChannel';

src/extension.web.ts

@@ -62,7 +62,6 @@ import { Common, OutputChannelNames } from './platform/common/utils/localize';
 import { IServiceContainer, IServiceManager } from './platform/ioc/types';
 import { sendErrorTelemetry, sendStartupTelemetry } from './platform/telemetry/startupTelemetry';
 import { noop } from './platform/common/utils/misc';
-import { PythonExtension } from './webviews/webview-side/common/constants';
 import { registerTypes as registerPlatformTypes } from './platform/serviceRegistry.web';
 import { registerTypes as registerTelemetryTypes } from './platform/telemetry/serviceRegistry.web';
 import { registerTypes as registerKernelTypes } from './kernels/serviceRegistry.web';
@@ -73,7 +72,13 @@ import { registerTypes as registerTerminalTypes } from './platform/terminals/ser
 import { registerTypes as registerStandaloneTypes } from './standalone/serviceRegistry.web';
 import { registerTypes as registerWebviewTypes } from './webviews/extension-side/serviceRegistry.web';
 import { IExtensionActivationManager } from './platform/activation/types';
-import { isCI, isTestExecution, JUPYTER_OUTPUT_CHANNEL, STANDARD_OUTPUT_CHANNEL } from './platform/common/constants';
+import {
+    isCI,
+    isTestExecution,
+    JUPYTER_OUTPUT_CHANNEL,
+    PythonExtension,
+    STANDARD_OUTPUT_CHANNEL
+} from './platform/common/constants';
 import { getJupyterOutputChannel } from './standalone/devTools/jupyterOutputChannel';
 import { registerLogger, setLoggingLevel } from './platform/logging';
 import { Container } from 'inversify/lib/container/container';

src/intellisense/logReplayService.node.ts

@@ -9,12 +9,11 @@ import * as lspConcat from '@vscode/lsp-notebook-concat';
 import * as protocol from 'vscode-languageserver-protocol';
 import { IExtensionSingleActivationService } from '../platform/activation/types';
 import { ICommandManager, IApplicationShell } from '../platform/common/application/types';
-import { PYTHON_LANGUAGE, NOTEBOOK_SELECTOR } from '../platform/common/constants';
+import { PYTHON_LANGUAGE, NOTEBOOK_SELECTOR, Commands, EditorContexts } from '../platform/common/constants';
 import { ContextKey } from '../platform/common/contextKey';
 import { traceInfo } from '../platform/logging';
 import { IFileSystemNode } from '../platform/common/platform/types.node';
 import { IDisposableRegistry, IConfigurationService } from '../platform/common/types';
-import { Commands, EditorContexts } from '../webviews/webview-side/common/constants';
 import { sleep, waitForCondition } from '../platform/common/utils/async';
 import { noop, swallowExceptions } from '../platform/common/utils/misc';
 

src/interactive-window/interactiveWindow.ts

@@ -47,7 +47,7 @@ import { InteractiveCellResultError } from '../platform/errors/interactiveCellRe
 import { DataScience } from '../platform/common/utils/localize';
 import { createDeferred, Deferred } from '../platform/common/utils/async';
 import { IServiceContainer } from '../platform/ioc/types';
-import { SysInfoReason } from '../platform/messageTypes';
+import { SysInfoReason } from '../messageTypes';
 import { createOutputWithErrorMessageForDisplay } from '../platform/errors/errorUtils';
 import { INotebookExporter } from '../kernels/jupyter/types';
 import { IExportDialog, ExportFormat } from '../notebooks/export/types';

src/kernels/helpers.ts

@@ -25,7 +25,7 @@ import { isCI, PYTHON_LANGUAGE, Telemetry } from '../platform/common/constants';
 import { traceError, traceInfo, traceInfoIfCI, traceWarning } from '../platform/logging';
 import { getDisplayPath, getFilePath } from '../platform/common/platform/fs-paths';
 import { DataScience } from '../platform/common/utils/localize';
-import { SysInfoReason } from '../platform/messageTypes';
+import { SysInfoReason } from '../messageTypes';
 import { getNormalizedInterpreterPath, getInterpreterHash } from '../platform/pythonEnvironments/info/interpreter';
 import { getTelemetrySafeVersion } from '../platform/telemetry/helpers';
 import { EnvironmentType, PythonEnvironment } from '../platform/pythonEnvironments/info';

src/kernels/ipywidgets/commonMessageCoordinator.ts

@@ -18,7 +18,7 @@ import {
     IPyWidgetMessages,
     LoadIPyWidgetClassLoadAction,
     NotifyIPyWidgetWidgetVersionNotSupportedAction
-} from '../../platform/messageTypes';
+} from '../../messageTypes';
 import { IServiceContainer } from '../../platform/ioc/types';
 import { sendTelemetryEvent, Telemetry } from '../../telemetry';
 import { getTelemetrySafeHashedString } from '../../platform/telemetry/helpers';

src/kernels/ipywidgets/ipyWidgetMessageDispatcher.ts

@@ -13,7 +13,7 @@ import { IDisposable } from '../../platform/common/types';
 import { Deferred, createDeferred } from '../../platform/common/utils/async';
 import { noop } from '../../platform/common/utils/misc';
 import { deserializeDataViews, serializeDataViews } from '../../platform/common/utils/serializers';
-import { IPyWidgetMessages, IInteractiveWindowMapping } from '../../platform/messageTypes';
+import { IPyWidgetMessages, IInteractiveWindowMapping } from '../../messageTypes';
 import { sendTelemetryEvent, Telemetry } from '../../telemetry';
 import { IKernel, IKernelProvider, KernelSocketInformation } from '../types';
 import { WIDGET_MIMETYPE } from './constants';

src/kernels/ipywidgets/ipyWidgetMessageDispatcherFactory.ts

@@ -6,7 +6,7 @@
 import { inject, injectable } from 'inversify';
 import { Event, EventEmitter, NotebookDocument } from 'vscode';
 import { IDisposable, IDisposableRegistry } from '../../platform/common/types';
-import { IPyWidgetMessages } from '../../platform/messageTypes';
+import { IPyWidgetMessages } from '../../messageTypes';
 import { getAssociatedNotebookDocument } from '../helpers';
 import { IKernel, IKernelProvider } from '../types';
 import { IPyWidgetMessageDispatcher } from './ipyWidgetMessageDispatcher';

src/kernels/ipywidgets/ipyWidgetScriptSource.ts

@@ -6,7 +6,7 @@ import type * as jupyterlabService from '@jupyterlab/services';
 import { Event, EventEmitter, NotebookDocument, Uri } from 'vscode';
 import { traceError, traceInfo, traceVerbose, traceWarning } from '../../platform/logging';
 import { IDisposableRegistry, IConfigurationService, IHttpClient, IDisposable } from '../../platform/common/types';
-import { InteractiveWindowMessages, IPyWidgetMessages } from '../../platform/messageTypes';
+import { InteractiveWindowMessages, IPyWidgetMessages } from '../../messageTypes';
 import { sendTelemetryEvent, Telemetry } from '../../telemetry';
 import { IKernel, IKernelProvider } from '../types';
 import { IPyWidgetScriptSourceProvider } from './ipyWidgetScriptSourceProvider';

src/kernels/ipywidgets/types.ts

@@ -5,7 +5,7 @@
 
 import { Event, Uri } from 'vscode';
 import { IDisposable, IHttpClient } from '../../platform/common/types';
-import { IPyWidgetMessages } from '../../platform/messageTypes';
+import { IPyWidgetMessages } from '../../messageTypes';
 import { IKernel } from '../types';
 
 export interface IPyWidgetMessage {

src/platform/messageTypes.ts → src/messageTypes.ts

@@ -3,18 +3,18 @@
 'use strict';
 import { Uri } from 'vscode';
 import type { KernelMessage } from '@jupyterlab/services';
-import { NativeKeyboardCommandTelemetry, NativeMouseCommandTelemetry } from '../platform/common/constants';
+import { NativeKeyboardCommandTelemetry, NativeMouseCommandTelemetry } from './platform/common/constants';
 import {
     IVariableExplorerHeight,
     CommonActionType
     // eslint-disable-next-line
-} from '../webviews/webview-side/interactive-common/redux/reducers/types';
+} from './webviews/webview-side/interactive-common/redux/reducers/types';
 // eslint-disable-next-line
-import { BaseReduxActionPayload } from '../webviews/types';
-import { WidgetScriptSource } from '../kernels/ipywidgets/types';
-import { KernelConnectionMetadata, KernelSocketOptions } from '../kernels/types';
-import { ICell } from './common/types';
-import { IJupyterVariable, IJupyterVariablesRequest, IJupyterVariablesResponse } from '../kernels/variables/types';
+import { BaseReduxActionPayload } from './webviews/types';
+import { WidgetScriptSource } from './kernels/ipywidgets/types';
+import { KernelConnectionMetadata, KernelSocketOptions } from './kernels/types';
+import { ICell } from './platform/common/types';
+import { IJupyterVariable, IJupyterVariablesRequest, IJupyterVariablesResponse } from './kernels/variables/types';
 
 export type NotifyIPyWidgetWidgetVersionNotSupportedAction = {
     moduleName: 'qgrid';

src/notebooks/controllers/vscodeNotebookController.ts

@@ -55,7 +55,7 @@ import { EnvironmentType } from '../../platform/pythonEnvironments/info';
 import { Commands } from '../../platform/common/constants';
 import { Telemetry } from '../../telemetry';
 import { WrappedError } from '../../platform/errors/types';
-import { IPyWidgetMessages } from '../../platform/messageTypes';
+import { IPyWidgetMessages } from '../../messageTypes';
 import {
     getKernelConnectionPath,
     getRemoteKernelSessionInformation,

src/notebooks/outputs/errorRendererComms.ts

@@ -23,7 +23,7 @@ import {
 } from '../../platform/common/application/types';
 import { IFileSystem } from '../../platform/common/platform/types';
 import { IDisposableRegistry } from '../../platform/common/types';
-import { InteractiveWindowMessages } from '../../platform/messageTypes';
+import { InteractiveWindowMessages } from '../../messageTypes';
 import { linkCommandAllowList, LineQueryRegex } from './linkProvider';
 
 @injectable()