Skip to content

Commit

Permalink
Use module Augmentation to merge API types (#14082)
Browse files Browse the repository at this point in the history
* Move display names into Jupyter Server Uri storage

* fix formatting

* Avoid validation of Jupyter Server providers

* Stop using display name from Uri storage

* Use module Augmentation to merge API types

* Fix linter

* fix formatting
  • Loading branch information
DonJayamanne authored Aug 9, 2023
1 parent cfe6615 commit bcc1136
Show file tree
Hide file tree
Showing 17 changed files with 400 additions and 400 deletions.
2 changes: 1 addition & 1 deletion src/api.proposed.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

export interface JupyterAPI {}
//
14 changes: 8 additions & 6 deletions src/api.pythonIntegration.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@

import { PythonApi } from './platform/api/types';

/**
* These types are not required for any other extension, except for the Python extension.
* Hence the reason to keep this separate. This way we can keep the API stable for other extensions (which would be the majority case).
*/
export interface JupyterAPI {
registerPythonApi(pythonApi: PythonApi): void;
declare module './api' {
/**
* These types are not required for any other extension, except for the Python extension.
* Hence the reason to keep this separate. This way we can keep the API stable for other extensions (which would be the majority case).
*/
export interface JupyterAPI {
registerPythonApi(pythonApi: PythonApi): void;
}
}
Loading

0 comments on commit bcc1136

Please sign in to comment.