API update for selection change (#5516)

microsoft · Apr 14, 2021 · f6e1d06 · f6e1d06
1 parent 9e2d5aa
commit f6e1d06
Show file tree

Hide file tree

Showing 5 changed files with 898 additions and 817 deletions.
diff --git a/news/2 Fixes/5515.md b/news/2 Fixes/5515.md
@@ -0,0 +1 @@
+Update to new selections API.
diff --git a/src/test/datascience/notebook/helper.ts b/src/test/datascience/notebook/helper.ts
@@ -84,7 +84,7 @@ async function getServices() {
 
 export async function selectCell(notebook: NotebookDocument, start: number, end: number) {
     await window.showNotebookDocument(notebook, {
-        selection: new NotebookCellRange(start, end)
+        selections: [new NotebookCellRange(start, end)]
     });
 }
 

diff --git a/types/vscode-proposed/index.d.ts b/types/vscode-proposed/index.d.ts
@@ -267,12 +267,6 @@ export interface NotebookEditor {
      */
     readonly document: NotebookDocument;
 
-    /**
-     * @deprecated
-     */
-    // todo@API should not be undefined, rather a default
-    readonly selection?: NotebookCell;
-
     /**
      * todo@API should replace selection
      * The selections on this notebook editor.
@@ -418,7 +412,7 @@ export interface NotebookDocumentShowOptions {
     viewColumn?: ViewColumn;
     preserveFocus?: boolean;
     preview?: boolean;
-    selection?: NotebookCellRange;
+    selections?: NotebookCellRange[];
 }
 
 export namespace notebook {