Update dependencies in package-lock.json (#14578)

* Update dependencies in package-lock.json * Add noop import and handle promise rejections in maximizeEditorGroup and collapseAllCellInputs commands.
microsoft · Oct 27, 2023 · f8a0ff9 · f8a0ff9
1 parent 971cac0
commit f8a0ff9
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 33 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/test/datascience/widgets/standardWidgets.vscode.common.test.ts b/src/test/datascience/widgets/standardWidgets.vscode.common.test.ts
@@ -39,6 +39,7 @@ import { initializeWidgetComms, Utils } from './commUtils';
 import { WidgetRenderingTimeoutForTests } from './constants';
 import { getTextOutputValue } from '../../../kernels/execution/helpers';
 import { isWeb } from '../../../platform/common/utils/misc';
+import { noop } from '../../core';
 
 const templateRootPath: Uri =
     workspace.workspaceFolders && workspace.workspaceFolders.length > 0
@@ -133,8 +134,8 @@ suite('Standard IPyWidget Tests @widgets', function () {
         // and the output is not visible, then it will not get rendered & the tests will fail. The tests inspect the rendered HTML.
         // Solution - maximize available real-estate by hiding the output panels & hiding the input cells.
         await commands.executeCommand('workbench.action.closePanel');
-        await commands.executeCommand('workbench.action.maximizeEditorGroup');
-        await commands.executeCommand('notebook.cell.collapseAllCellInputs');
+        await commands.executeCommand('workbench.action.maximizeEditorGroup').then(noop, noop);
+        await commands.executeCommand('notebook.cell.collapseAllCellInputs').then(noop, noop);
         comms = await initializeWidgetComms(disposables);
 
         vscodeNotebook = api.serviceContainer.get<IVSCodeNotebook>(IVSCodeNotebook);

diff --git a/src/test/datascience/widgets/thirdpartyWidgets.vscode.common.test.ts b/src/test/datascience/widgets/thirdpartyWidgets.vscode.common.test.ts
@@ -37,6 +37,7 @@ import { GlobalStateKeyToTrackIfUserConfiguredCDNAtLeastOnce } from '../../../no
 import { initializeWidgetComms, Utils } from './commUtils';
 import { isWeb } from '../../../platform/common/utils/misc';
 import { getTextOutputValue } from '../../../kernels/execution/helpers';
+import { noop } from '../../core';
 
 [true, false].forEach((useCDN) => {
     /* eslint-disable @typescript-eslint/no-explicit-any, no-invalid-this */
@@ -80,7 +81,7 @@ import { getTextOutputValue } from '../../../kernels/execution/helpers';
             // and the output is not visible, then it will not get rendered & the tests will fail. The tests inspect the rendered HTML.
             // Solution - maximize available real-estate by hiding the output panels & hiding the input cells.
             await commands.executeCommand('workbench.action.closePanel');
-            await commands.executeCommand('workbench.action.maximizeEditorGroup');
+            await commands.executeCommand('workbench.action.maximizeEditorGroup').then(noop, noop);
             comms = await initializeWidgetComms(disposables);
 
             vscodeNotebook = api.serviceContainer.get<IVSCodeNotebook>(IVSCodeNotebook);