Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with Notebook debugger (using Jupyter Protocol) #10106

Closed
Tracked by #10037
DonJayamanne opened this issue May 24, 2022 · 7 comments
Closed
Tracked by #10037

Problems with Notebook debugger (using Jupyter Protocol) #10106

DonJayamanne opened this issue May 24, 2022 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-debugging papercut 🩸 Something affecting the productivity of the team verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented May 24, 2022

Note: These issues have been fixed for IW debugger, we need to fix them for Notebook

  • Problem 1:

    • Cell 1
      < empty line>
      < empty line>	  
      < empty line>
      < empty line>
      print(1)
      print(2)

    When debugging the above code, the debugger will stop at line print(1), however when you hit step over in RBL or continue in the cell debugger it will break there once again.

  • Problem 2:

    • Cell 1
      < empty line>
      < empty line>	  
      < empty line>
      def foo():
          print('inside foo')
      • Cell 2
      foo()
      When debugging the above code, the debugger will stop at line foo(), however when you step into the code, it will stop way above the def foo, in a white space (basically on line 2 of the file, in the white space).
  • Problem 3:
    The above issues were uncovered while running some of the IW debugger tests.
    I think we need a few more tests for the notebook debugger to cover the same scenarios covered in IW debugger.

These issues have been fixed in the new IW when using debugger protocol.
Basically injecting breakpiont() along with a few other changes.

@roblourens
Copy link
Member

I can't repro issue 1 in a notebook. I see issue 2 though, didn't know that Jupyter does this

@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented May 25, 2022

@roblourens the empty lines were stripped by Github when rendering the sample code I added above... lol, Jupyter does the same,
Try with the leading empty lines (as per udpated sample code - which clearly shows where we need empty lines).

@ttSpace

This comment was marked as off-topic.

@DonJayamanne
Copy link
Contributor Author

@ttSpace
please could you file a separate issue for that.

@microsoft microsoft locked as resolved and limited conversation to collaborators Jun 6, 2022
@greazer greazer added this to the June 2022 milestone Jun 8, 2022
@greazer greazer added papercut 🩸 Something affecting the productivity of the team and removed interactive-window-debugging labels Jun 10, 2022
@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Jun 27, 2022

Upstream issue microsoft/debugpy#964 & microsoft/debugpy#869

@DonJayamanne DonJayamanne removed this from the June 2022 milestone Jun 27, 2022
@DonJayamanne DonJayamanne removed their assignment Jun 27, 2022
@DonJayamanne DonJayamanne added this to the June 2022 milestone Jun 27, 2022
@DonJayamanne DonJayamanne self-assigned this Jun 27, 2022
@DonJayamanne
Copy link
Contributor Author

Issues with empty lines will not be resolved for now (as it was reported by me and a papercut),
Creating a new issue to track breakpoint issue caused by upstream python debgger #10600

@rzhao271 rzhao271 added verified Verification succeeded and removed verified Verification succeeded labels Jul 1, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Jul 1, 2022
@roblourens
Copy link
Member

Was problem 2 supposed to be fixed by the debugpy update?

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-debugging papercut 🩸 Something affecting the productivity of the team verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants