Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for IW debugger using the Jupyter Protocol on the web #10107

Closed
2 of 3 tasks
Tracked by #10037
DonJayamanne opened this issue May 24, 2022 · 2 comments · Fixed by #10297
Closed
2 of 3 tasks
Tracked by #10037

Add tests for IW debugger using the Jupyter Protocol on the web #10107

DonJayamanne opened this issue May 24, 2022 · 2 comments · Fixed by #10297
Assignees
@DonJayamanne
Labels
debt Code quality issues interactive-window-debugging
Milestone
June 2022

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented May 24, 2022 •
edited
Loading

  • Test debugging local connections using the Jupyter protocol (done here #10263)
  • Test debugging remote connections using the Jupyter protocol (done here #10263)
  • Test debugging remote connections using the Jupyter protocol on the web

Blocked on Add tests for IW on web
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label May 24, 2022
@DonJayamanne DonJayamanne self-assigned this May 24, 2022
@DonJayamanne DonJayamanne added this to the May 2022 milestone May 24, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label May 24, 2022
This was referenced May 24, 2022
Merged
Closed
@rchiodo
Copy link
Contributor

rchiodo commented Jun 2, 2022

I assume this isn't actually done?

@rchiodo rchiodo reopened this Jun 2, 2022
@DonJayamanne DonJayamanne changed the title Add tests for IW debugger using the Jupyter Protocol Add tests for IW debugger using the Jupyter Protocol on the web Jun 3, 2022
@DonJayamanne DonJayamanne mentioned this issue Jun 3, 2022
Merged
4 tasks
@rchiodo rchiodo modified the milestones: May 2022, June 2022 Jun 3, 2022
DonJayamanne added a commit that referenced this issue Jun 3, 2022
@DonJayamanne
Enable debugging IW in vscode.web and add tests for IW on web (#10297)
8de113e 
**Changes/Fixes**
* [x] Enables tests for IW on the web (required for this PR and for testing IW debugging)
* [x] Enables the code lenses to debug cells in IW (this was disabled)
* [x] Enables code lenses for running of cells in IW 
	Currently we only enable this for file schemes, i.e. if you open desktop files in web, meaning it will not work for other file systems like github or the like. 
* [x] Adds a common set of tests for Web & desktop instead of having to create 3 files, ie one test file  `*.vscode.common.test.ts` that will run in both places


Fixes #10296
Fixes #10107
@connor4312
Copy link
Member

@DonJayamanne this seems like a debt item--if not, are there verification steps for this?

@connor4312 connor4312 added the verification-steps-needed Steps to verify are needed for verification label Jun 29, 2022
@DonJayamanne DonJayamanne added debt Code quality issues interactive-window-debugging vscode-web and removed bug Issue identified by VS Code Team member as probable bug verification-steps-needed Steps to verify are needed for verification triage-needed Issue needs to be triaged labels Jun 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Code quality issues interactive-window-debugging
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

Enable debugging IW in vscode.web and add tests for IW on web microsoft/vscode-jupyter
3 participants
@DonJayamanne @connor4312 @rchiodo