Fixes to IW debugging with breakpoints #10263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Jun 2, 2022
| (bp) => bp.line <= cell.metadata.generatedCode!.endLine | ||
| ); | ||
| } | ||
| if (sortedLines.filter((line) => line > cell.metadata.generatedCode!.endLine).length) { |
There was a problem hiding this comment.
@rchiodo we add breakpoints for each cell by splitting the breakpoints by cells.
There was a problem hiding this comment.
Is breakpoints the only thing that needs this special translation? What about stack frames?
rchiodo
reviewed
Jun 2, 2022
| } | ||
| // Find the cell that matches this line in the IW file. | ||
| const cell = this.cellToDebugFileSortedInReverseOrderByLineNumber.find( | ||
| (item) => item.debugFilePath === source.path |
There was a problem hiding this comment.
Comment seems wrong here. It's not searching by line but rather by the translated debugFilePath. That does map to a specific cell entry.
|
Tests are actually already there, you just need to undo the changes I made for this issue. Then they'll run the normal tests. |
rchiodo
approved these changes
Jun 2, 2022
|
Oh wait I shouldn't have approved. You should undo the changes I made here: and here |
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #10263 +/- ##
=====================================
- Coverage 64% 64% -1%
=====================================
Files 204 204
Lines 9287 9295 +8
Branches 1504 1505 +1
=====================================
+ Hits 5963 5966 +3
- Misses 2854 2857 +3
- Partials 470 472 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10258
Will add tests next week.