Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for IW on web #10296

Closed
DonJayamanne opened this issue Jun 3, 2022 · 0 comments · Fixed by #10297
Closed

Add tests for IW on web #10296

DonJayamanne opened this issue Jun 3, 2022 · 0 comments · Fixed by #10297
Labels
bug Issue identified by VS Code Team member as probable bug triage-needed Issue needs to be triaged

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jun 3, 2022 •
edited
Loading

I could be wrong, but I couldn't find any tests for IW on the web.
Came across this when attempting to enable web tests for IW debugger.

@amunger please feel free to close this if this is being tracked anywhere else or if this is a duplicate issue.

I had to create some tests for the IW web debugger, hence looked into this,
I've enabled the tests in here #10297
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Jun 3, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 3, 2022
@DonJayamanne DonJayamanne changed the title Enable tests for IW on web Add tests for IW on web Jun 3, 2022
This was referenced Jun 3, 2022
Closed
Merged
DonJayamanne added a commit that referenced this issue Jun 3, 2022
@DonJayamanne
Enable debugging IW in vscode.web and add tests for IW on web (#10297)
8de113e 
**Changes/Fixes**
* [x] Enables tests for IW on the web (required for this PR and for testing IW debugging)
* [x] Enables the code lenses to debug cells in IW (this was disabled)
* [x] Enables code lenses for running of cells in IW 
	Currently we only enable this for file schemes, i.e. if you open desktop files in web, meaning it will not work for other file systems like github or the like. 
* [x] Adds a common set of tests for Web & desktop instead of having to create 3 files, ie one test file  `*.vscode.common.test.ts` that will run in both places


Fixes #10296
Fixes #10107
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug triage-needed Issue needs to be triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable debugging IW in vscode.web and add tests for IW on web microsoft/vscode-jupyter
1 participant
@DonJayamanne