Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kind ordering for kernels is 'english' specific #10656

Closed
rchiodo opened this issue Jun 30, 2022 · 3 comments
Closed

Kind ordering for kernels is 'english' specific #10656

rchiodo opened this issue Jun 30, 2022 · 3 comments
Assignees
Labels

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Jun 30, 2022

See the code here:
https://github.com/rchiodo/vscode/blob/4cf4438fc001e0c925905af51577cfc1db72f42c/src/vs/workbench/contrib/notebook/browser/contrib/editorStatusBar/editorStatusBar.ts#L204

I copied this code on this pr as well:
#10602

Both should be made locale aware.

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Jun 30, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 30, 2022
@DonJayamanne DonJayamanne added localization and removed triage-needed Issue needs to be triaged labels Jun 30, 2022
@IanMatthewHuff IanMatthewHuff removed their assignment Nov 10, 2022
@DonJayamanne DonJayamanne added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Nov 24, 2022
@DonJayamanne DonJayamanne self-assigned this Dec 6, 2022
@DonJayamanne
Copy link
Contributor

@brettcannon are the types of environments like Virtual Env, Conda localizable?
Are you planning on localizing these in Python extension.
Asking as things could look different and weird if they're localized in one and not the other.
I personally feel localizing this would make sense,

@brettcannon
Copy link
Member

are the types of environments like Virtual Env, Conda localizable?

"Virtual env" is possible, but "conda" is not as that's a product name.

Are you planning on localizing these in Python extension.

No specific plans, but it's definitely a reasonable ask. I have opened microsoft/vscode-python#20346 .

@DonJayamanne
Copy link
Contributor

Haven't had enough upvotes on this issue, hence closing this issue for now

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants