Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize section separators for the environment quick pick #20346

Closed
brettcannon opened this issue Dec 7, 2022 · 2 comments
Closed

Localize section separators for the environment quick pick #20346

brettcannon opened this issue Dec 7, 2022 · 2 comments
Assignees
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team

Comments

@brettcannon
Copy link
Member

E.g. "Virtual Env" probably has some translation in other languages (https://docs.python.org/3/library/venv.html#module-venv seems to suggest some translation). Probably can't translate "conda" since that's a product name.

@brettcannon brettcannon added the feature-request Request for new features or functionality label Dec 7, 2022
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Dec 7, 2022
@eleanorjboyd eleanorjboyd added needs PR Ready to be worked on area-environments Features relating to handling interpreter environments and removed triage-needed Needs assignment to the proper sub-team labels Dec 8, 2022
@karrtikr
Copy link

Here're our separators which are already localized:

export namespace EnvGroups {
export const Workspace = InterpreterQuickPickList.workspaceGroupName;
export const Conda = 'Conda';
export const Global = InterpreterQuickPickList.globalGroupName;
export const VirtualEnv = 'VirtualEnv';
export const PipEnv = 'PipEnv';
export const Pyenv = 'Pyenv';
export const Venv = 'Venv';
export const Poetry = 'Poetry';
export const VirtualEnvWrapper = 'VirtualEnvWrapper';
export const Recommended = Common.recommended;
}

VirtualEnv is also a product name: https://pypi.org/project/virtualenv/, so things are probably okay as it is.

@karrtikr karrtikr added info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team and removed needs PR Ready to be worked on labels Dec 13, 2022
@brettcannon
Copy link
Member Author

Great! Then I will assume @DonJayamanne was asking generically and not due to a specific string not showing up as translated.

@brettcannon brettcannon closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team
Projects
None yet
Development

No branches or pull requests

4 participants