Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release builds are broken #10729

Closed
DonJayamanne opened this issue Jul 7, 2022 · 3 comments · Fixed by #10745
Closed

Pre-release builds are broken #10729

DonJayamanne opened this issue Jul 7, 2022 · 3 comments · Fixed by #10745
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug triage-needed Issue needs to be triaged

Comments

@DonJayamanne
Copy link
Contributor

From what I can tell we can build pre-releases from the commit before this, but not after this 24eaf02

Basically broken after this PR #10712

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Jul 7, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jul 7, 2022
@sadasant sadasant self-assigned this Jul 8, 2022
@sadasant
Copy link
Contributor

sadasant commented Jul 8, 2022

I started investigating this, but I couldn't think of anything specific that could be causing the problem.

In the short run, we can revert my PR and get the build out. How does that sound?

I have also asked @TylerLeonhardt for help.

@IanMatthewHuff
Copy link
Member

You might already have this, but this looks like the error from the translation tools:

2022-07-08T09:09:24.0994773Z [09:09:24] TypeError: Cannot read properties of undefined (reading 'length')
2022-07-08T09:09:24.0995836Z     at encodeEntities (/mnt/vss/_work/1/translations-tools/node_modules/vscode-nls-dev/lib/main.js:544:31)
2022-07-08T09:09:24.0996673Z     at XLF.addFile (/mnt/vss/_work/1/translations-tools/node_modules/vscode-nls-dev/lib/main.js:355:29)
2022-07-08T09:09:24.0997552Z     at Stream.<anonymous> (/mnt/vss/_work/1/translations-tools/node_modules/vscode-nls-dev/lib/main.js:477:22)
2022-07-08T09:09:24.0998357Z     at Stream.stream.write (/mnt/vss/_work/1/translations-tools/node_modules/through/index.js:26:11)
2022-07-08T09:09:24.0999209Z     at DestroyableTransform.ondata (/mnt/vss/_work/1/translations-tools/node_modules/readable-stream/lib/_stream_readable.js:619:20)
2022-07-08T09:09:24.0999828Z     at DestroyableTransform.emit (node:events:390:28)
2022-07-08T09:09:24.1000392Z     at DestroyableTransform.emit (node:domain:537:15)
2022-07-08T09:09:24.1001189Z     at addChunk (/mnt/vss/_work/1/translations-tools/node_modules/readable-stream/lib/_stream_readable.js:291:12)
2022-07-08T09:09:24.1002107Z     at readableAddChunk (/mnt/vss/_work/1/translations-tools/node_modules/readable-stream/lib/_stream_readable.js:278:11)
2022-07-08T09:09:24.1002894Z     at DestroyableTransform.Readable.push (/mnt/vss/_work/1/translations-tools/node_modules/readable-stream/lib/_stream_readable.js:245:10)

@TylerLeonhardt
Copy link
Member

please don't revert this I have a fix

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug triage-needed Issue needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants