Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed localizations #10712

Merged
merged 10 commits into from
Jul 6, 2022
Merged

Fixed localizations #10712

merged 10 commits into from
Jul 6, 2022

Conversation

sadasant
Copy link
Contributor

@sadasant sadasant commented Jul 6, 2022

Fixed localization on package.json sections: capabilities, contributes.walkthroughs, contributes.commands and contributes.debuggers. As well as the localizations on the exceptions thrown if the extension fails to activate and the localization on the messages for deprecated features.

My approach was as follows:

  • In package.json, I used [a-zA-Z]+ [a-zA-Z]+ to find for pseudo-english strings.
  • Outside of package.json, I used "[a-zA-Z]+ [a-zA-Z]+ to search. Excluding files: *.d.ts,*test.ts,localize.ts,testData.ts.
    • Inevitably found many results in the comments, but I omitted those.
  • Ensured that no unnecessary duplications existed by: Removing all the keys on package.nls.json, then running sort package.nls.json | uniq -cd to find the duplicated values. There are some, but they seem not necessary to optimize to me.
  • Proceeded to read each one of the localizations I was adding to find sensitive content that should be excluded form translations. Keeping in mind that our translators are very technically capable.

I believe there are no other places to localize now.

Fixes #10624

Feedback always appreciated!

@sadasant sadasant self-assigned this Jul 6, 2022
@sadasant sadasant requested a review from a team as a code owner July 6, 2022 19:55
@sadasant sadasant merged commit 24eaf02 into microsoft:main Jul 6, 2022
@sadasant sadasant deleted the debt/10624 branch July 6, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings strings are not localized
3 participants