Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undoing command localizations #10763

Conversation

sadasant
Copy link
Contributor

At the time I did this PR I assumed that, given that the other aspects of localization were a success, my changes would not have any drawback. I was wrong! This PR #10712 introduces a serious issue: the lack of translations seems to be preventing the extension to load properly, causing the restart and interrupt buttons on the global toolbar to disappear (probably among other things).

This issue is related: microsoft/vscode#154955

How does this look? What else should we do?
Feedback appreciated.

@sadasant sadasant self-assigned this Jul 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #10763 (015313b) into main (df705f5) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   microsoft/vscode-jupyter#10763   +/-   ##
======================================
  Coverage     63%      63%           
======================================
  Files        476      476           
  Lines      32981    32981           
  Branches    5356     5356           
======================================
+ Hits       20789    20794    +5     
+ Misses     10194    10190    -4     
+ Partials    1998     1997    -1     
Impacted Files Coverage Δ
src/platform/debugger/debugger.ts 66% <0%> (-12%) ⬇️
src/notebooks/outputs/tracebackFormatter.ts 93% <0%> (-7%) ⬇️
src/notebooks/debugger/debuggingManagerBase.ts 69% <0%> (-7%) ⬇️
src/platform/common/utils/async.ts 50% <0%> (-1%) ⬇️
src/kernels/debugger/kernelDebugAdapterBase.ts 79% <0%> (-1%) ⬇️
src/platform/common/utils/localize.ts 75% <0%> (-1%) ⬇️
src/kernels/raw/launcher/kernelProcess.node.ts 70% <0%> (+<1%) ⬆️
src/notebooks/notebookCommandListener.ts 53% <0%> (+1%) ⬆️
src/kernels/kernel.base.ts 83% <0%> (+1%) ⬆️
src/kernels/execution/kernelExecution.ts 71% <0%> (+1%) ⬆️
... and 3 more

@sadasant
Copy link
Contributor Author

Some things we know:

  • Switching to version 5.100 does fix the problem.
  • The localization changes that I did on PR Fixed localizations #10712 are not part of the released 6.100 version of our extension.
  • The package.nls.es.json in 6.100 has nothing I can identify as wrong or broken.

That means, at the very least, that reverting my PR won’t do anything.

@sadasant sadasant closed this Jul 11, 2022
@sadasant sadasant deleted the reverse-packagejson-commands-localizations branch July 11, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants