Respect VSCode's telemetry setting

[PeterJCLaw]

Environment data

• VS Code version: 1.69.2
• Jupyter Extension version (available under the Extensions sidebar): v2022.6.1201981810
• OS (Windows | Mac | Linux distro) and version: Ubuntu 20.04 LTS

Expected behaviour

When VSCode's telemetry preference is set to a restricted value (e.g: off, crash) the extension should not query for or send telemetry.

Actual behaviour

I observed lines such as printenv > /tmp/tmp-45935fdNhOTkd5hRYtxt in my shell history and via https://twitter.com/ferrouswheel/status/1551353490949017600 traced this to having (hopefully!) come from this extension

vscode-jupyter/src/platform/terminals/helper.node.ts

Lines 81 to 93 in 545c0a7

	switch (this.shellDetector.identifyTerminalShell(terminal)) {
	case TerminalShellType.powershellCore:
	case TerminalShellType.powershell:
	command = `Get-ChildItem Env: | Select Name | Export-Csv -Path ${filePath.fileToCommandArgument()} -NoTypeInformation`;
	break;
	case TerminalShellType.commandPrompt:
	command = `set > ${filePath.fileToCommandArgument()}`;
	break;
	default:
	command = `printenv > ${filePath.fileToCommandArgument()}`;
	break;
	}

I have telemetry.telemetryLevel set to off on the machine where this was observed.

Ideally the extension should not gather telemetry data outside the enabled telemetry remit.

[rchiodo]

Thanks for the issue.

The data may be gathered but the way the code is setup, it isn't sent. Turning telemetry off doesn't affect the internal behavior of the extension, it merely prevents the data from being sent anywhere.

We use this npm module to send our telemetry. It determines if the telemetry data is sent or not:
https://github.com/microsoft/vscode-extension-telemetry/blob/5d778578cb8484d3336549f2b6b667fa9f0411b1/src/common/baseTelemetryReporter.ts#L301

[r3m0t]

It isn't telemetry, it's used in the code to launch your Jupyter kernels and Jupyter server.

vscode-jupyter/src/kernels/raw/finder/jupyterPaths.node.ts

Line 352 in 545c0a7

const vars = await this.envVarsProvider.getEnvironmentVariables(undefined, 'RunPythonCode');

vscode-jupyter/src/kernels/jupyter/jupyterKernelService.node.ts

Line 286 in 545c0a7

specModel.env = await this.kernelEnvVars.getEnvironmentVariables(resource, interpreter, specedKernel);

[rchiodo]

Those are not the same 'getEnvironmentVariables' calls. The one adding to the shell history is only used in our jupyter install telemetry.

[DonJayamanne]

Closing as a duplicate of #10935