Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop creating hidden terms to look for Jupyter app #10986

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Conversation

DonJayamanne
Copy link
Contributor

Fixes #10934

@DonJayamanne DonJayamanne requested a review from a team as a code owner July 31, 2022 16:54
@codecov-commenter
Copy link

Codecov Report

Merging #10986 (20fc833) into main (5ff36bf) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main   #10986    +/-   ##
=======================================
- Coverage     63%      63%    -1%     
=======================================
  Files        482      482            
  Lines      33851    33829    -22     
  Branches    5518     5511     -7     
=======================================
- Hits       21468    21363   -105     
- Misses     10339    10430    +91     
+ Partials    2044     2036     -8     
Impacted Files Coverage Δ
.../kernels/jupyter/jupyterDetectionTelemetry.node.ts 88% <ø> (+14%) ⬆️
src/platform/terminals/helper.node.ts 23% <0%> (-56%) ⬇️
src/platform/terminals/shellDetector.node.ts 29% <0%> (-55%) ⬇️
...s/shellDetectors/terminalNameShellDetector.node.ts 35% <0%> (-51%) ⬇️
...terminals/shellDetectors/baseShellDetector.node.ts 70% <0%> (-30%) ⬇️
...latform/common/application/terminalManager.node.ts 33% <0%> (-23%) ⬇️
...inals/shellDetectors/settingsShellDetector.node.ts 24% <0%> (-13%) ⬇️
...shellDetectors/vscEnvironmentShellDetector.node.ts 35% <0%> (-12%) ⬇️
...hellDetectors/userEnvironmentShellDetector.node.ts 23% <0%> (-7%) ⬇️
... and 8 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect VSCode's telemetry setting
4 participants