Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getKernelConnectionId doesn't always work #4194

Closed
DonJayamanne opened this issue Dec 9, 2020 · 1 comment
Closed

getKernelConnectionId doesn't always work #4194

DonJayamanne opened this issue Dec 9, 2020 · 1 comment

Comments

@DonJayamanne
Copy link
Contributor

See comments here by @IanMatthewHuff #4192 (comment)

Ideally this function should always return the same thing regarless of the environment & interpreter selected.
One possible suggestion is to not include the property kernelConneciton.interpreter when computing the kernel Connection Id.

I think this needs to be addressed, else this function doesn't really return a unique id.
If resolved, then we can use this function in places like the function where we're checking if the kernel spec is the same or not (see this PR #4192 (comment)).

I.e. have a single way to compare kernel connection metadata

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug internal contributor labels Dec 9, 2020
@greazer greazer removed the bug Issue identified by VS Code Team member as probable bug label Dec 10, 2020
@DonJayamanne
Copy link
Contributor Author

This issue was added as we could not use getKernelConnectionId to address the issue in #4192 & #4109
However that's caused by an upstream VS Code bug, hence there's no need to fix this bug #4332

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants