Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode invokes provideKernels every time we change tabs between notebooks #4332

Closed
DonJayamanne opened this issue Jan 8, 2021 · 7 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug upstream-vscode Blocked on upstream VS code

Comments

@DonJayamanne
Copy link
Contributor

Upstream issue microsoft/vscode#114048
This was partially fixed here #4192

However the kernel has already been changed in the notebook editor & that causes other issues.
the root cause is with VS Code & we cannot tell what the previously selected kernel was/is.

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug blocked upstream-vscode Blocked on upstream VS code labels Jan 8, 2021
@DonJayamanne DonJayamanne self-assigned this Jan 8, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Feb 9, 2021

This still occurs. provideKernels is called on every tab switch.

@greazer
Copy link
Member

greazer commented Feb 10, 2021

What is the user-facing result of this problem?

@DonJayamanne
Copy link
Contributor Author

What is the user-facing result of this problem?

The active kernel could change behind the scenes.
We need to validate this.
Ian reported this issue:

  • Open a notebook, slect kernel A
  • Open another notebook select Kernel b
  • Tab between the two & the first notebook will end up with some other kernel (even when user didn not change this_

I thought VS Code fixed this, we need to validate this.
I think VSCode calling the funciton is OK, provided the kernel does not change just because of tabbing in/out.

@rchiodo
Copy link
Contributor

rchiodo commented Feb 10, 2021

Validated.

@rchiodo rchiodo closed this as completed Feb 10, 2021
@DonJayamanne DonJayamanne reopened this Feb 11, 2021
@DonJayamanne
Copy link
Contributor Author

microsoft/vscode#116504

@DonJayamanne
Copy link
Contributor Author

This will be resolved with VS Codes changes to how kernels are provided.

@DonJayamanne
Copy link
Contributor Author

Closing this issue as VS Code is planning on re-wamping the kernel provider API.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug upstream-vscode Blocked on upstream VS code
Projects
None yet
Development

No branches or pull requests

3 participants