Running the contributed command: 'jupyter.selectjupyteruri' failed

[clayms]

Issue Type: Bug
Recent update completely broke Jupyter.

Selecting ctrl+shift+p then Jupyter: Specify local or remote Jupyter server for connections gives the following error:

Command 'Jupyter: Specify local or remote Jupyter server for connections' resulted in an error (Running the contributed command: 'jupyter.selectjupyteruri' failed.)

Trying to run python code with Shift+Enter gives the following three errors simultaneously:

1. Unable to open 'Interactive - microsoft/vscode-python#1': Webview overlay is disposed.
2. e.toLowerCase is not a function
3. e.toLowerCase is not a function

Extension version: 2021.3.680753044
VS Code version: Code 1.55.0 (c185983a683d14c396952dd432459097bc7f757f, 2021-03-30T16:01:55.261Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz (4 x 2496)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on protected_video_decode: unavailable_off rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.88GB (6.38GB free)
Process Argv	--crash-reporter-id f652528b-5678-4b12-9ca0-3de6b1e1135f
Screen Reader	no
VM	0%

A/B Experiments

vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30276681
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30259475
pythontb:30283811
openwsldoc:30282072
vspre833cf:30267465
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820cf:30276953
pythondataviewer:30285071

[clayms]

The following seems to have fixed the issue, however, I don't think updating VS Code should cause this much hassle.

1. Deleted the following from my named.workspace file,

	"settings":  {
		 "jupyter.jupyterServerType": "remote"
	}

2. Restarted VS Code,
3. ctrl+shift+p then Jupyter: Clear Jupyter server list,
4. Ran python code with shift+enter in the local default python interpreter,
5. ctrl+shift+p then Jupyter: Specify local or remote Jupyter server for connections.

[IanMatthewHuff]

@clayms Apologies on this. We store the jupyter server URI in the vscode secret store, and anyone on Windows is getting hit by this VS Code issue here:
microsoft/vscode#120558
We're updating our code to clear out any secrets that hit this decryption failed message. That's basically what you did when you deleted the setting. After the secret is regenerated on 1.55 it should work from then on out.

[joyceerhl]

Seems to be working now with David's fix checked into main bits. At least if I run the 'Specify local or remote Jupyter server for connections' command from the command palette I get the usual quickpick:

@DavidKutu @IanMatthewHuff was there anything else to do as far as validation?

[IanMatthewHuff]

@joyceerhl were you reproing the issue before? I think the only way to repro this was if you had created a secret pre 1.55 on windows, then updated to 1.55 on windows and tried to access the same secret. I'm Mac so I've never actually seen the issue myself.

[joyceerhl]

Ah I wasn't reproing the issue before. I'll leave this for someone else to validate then.

[IanMatthewHuff]

@rchiodo I think you are our only other windows option. Were you seeing this? If you don't have it, then it's probably fine to just close. Code change is very simple and David did have the repro for fixing.

[rchiodo]

I'm not seeing that on insiders or stable. Specifying remote works fine and the quick pick always appears.

[clayms]

@rchiodo

@joyceerhl were you reproing the issue before? I think the only way to repro this was if you had created a secret pre 1.55 on windows, then updated to 1.55 on windows and tried to access the same secret. I'm Mac so I've never actually seen the issue myself.

[rchiodo]

Sorry that means in order to repro this I need to uninstall VS code, install 1.54, connect to remote, upgrade back to 1.55 and make sure to use the new bits in main in 1.55.

Is there a way to just corrupt the VS secret store?

[joyceerhl]

Validated. I did the following:

1. Install VS Code 1.54 and the March release (2021.3.x) of the Jupyter extension on the marketplace
2. Run `Specify local or remote Jupyter server for connections' to pick AML compute remote jupyter server
3. Open a blank notebook with the remote connection
4. Upgrade to VS Code 1.55.1 with the same 2021.3.x release of the Jupyter extension
5. Run 'Specify local or remote Jupyter server for connections' and verify the error message comes up:
   
6. Install the Jupyter vsix from this morning's bug bash
7. Run 'Specify local or remote Jupyter server for connections' and verify the quickpick comes up with no error message 🎉

@clayms we're planning to make this fix available in a point release early next week so I'm going to go ahead and close this issue. Please keep an eye out for that release, which should resolve this issue. Thanks for bringing this to our attention!