Delete extension context secrets if we get an error when getting them. #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small fixes on error handling.
DavidKutu
commented
Apr 6, 2021
| return val; | ||
| } catch (e) { | ||
| // If we get an error trying to get a secret, it might be corrupted. So we delete it. | ||
| await this.extensionContext.secrets.delete(`${service}.${key}`); |
There was a problem hiding this comment.
According to this issue microsoft/vscode#120558, an encryption change in Windows requires us to re enter every secret.
I checked and this is the only place in the repo where .get() gets called. So if we get an error while getting, we can delete and then enter the secret again as usual.
Thanks @IanMatthewHuff for the help.
There was a problem hiding this comment.
We considered what other secret could be affected by this, but it looks like its only the remote uri's.
DavidKutu
commented
Apr 6, 2021
| @@ -41,7 +41,9 @@ export function getLastFrameFromPythonTraceback( | |||
| } | |||
| // File "/Users/donjayamanne/miniconda3/envs/env3/lib/python3.7/site-packages/appnope/_nope.py", line 38, in C | |||
|
|
|||
| const lastFrame = traceback | |||
| // This parameter might be either a string or a string array | |||
| const fixedTraceback: string = Array.isArray(traceback) ? traceback[0] : traceback; | |||
There was a problem hiding this comment.
It makes more sense to change the parameter type, but the issue is that JS allows it to be either an array or a string. This works for both cases.
rchiodo
approved these changes
Apr 6, 2021
IanMatthewHuff
pushed a commit
that referenced
this pull request
Apr 8, 2021
#5426) Small fixes on error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And small fixes on error handling.
For #5419
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).