Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement persistent native interactive window sessions #6460

Closed
3 tasks
joyceerhl opened this issue Jun 30, 2021 · 1 comment
Closed
3 tasks

Implement persistent native interactive window sessions #6460

joyceerhl opened this issue Jun 30, 2021 · 1 comment
Labels
interactive-window Impacts interactive window

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented Jun 30, 2021

We recently implemented being able to restore the contents of the interactive window from backup between VS Code reloads. However, there are a number of issues that need to be resolved in order for this experience to work smoothly.

The current behavior:

  • Reload
  • Interactive window is still open with all the cells from the previous session
  • Mapping between Python file and interactive window is lost
  • Kernel is initially dead (killed on reload). After waiting a bit, the previously connected kernel gets restarted, and a new connection sys info cell is appended to the interactive window (weird behavior for users--user expectation here is that it's the same kernel connection)

Discussion topic: What is the meaning of hot exit, and why does it exist?
- Is it just about persisting the history in the interactive window, or is it also about having a persistent kernel connection?
- Currently the implementation supports the former, i.e. we keep the cells around but the kernel session is lost
- One perspective: if I reload VS Code, I don't want to lose my interactive window session--that means the mapping between the Python file and interactive window should still be there, and the kernel connection should still be live and I should not lose my kernel state #6420

Work items

@amunger
Copy link
Contributor

amunger commented Apr 18, 2022

Created a more up to date discussion thread for this

@amunger amunger closed this as completed Apr 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
interactive-window Impacts interactive window
Projects
None yet
Development

No branches or pull requests

3 participants