Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Debug Adapter traffic #6468

Closed
Tracked by #5607
DavidKutu opened this issue Jun 30, 2021 · 0 comments · Fixed by #7219
Closed
Tracked by #5607

Log Debug Adapter traffic #6468

DavidKutu opened this issue Jun 30, 2021 · 0 comments · Fixed by #7219
Assignees
Milestone

Comments

@DavidKutu
Copy link

DavidKutu commented Jun 30, 2021

This will make it easier to test performance and other issues. Like this one microsoft/vscode#127720.
Put it on the Jupyter output or on its own output.

@DavidKutu DavidKutu self-assigned this Jun 30, 2021
@roblourens roblourens assigned roblourens and unassigned DavidKutu Aug 21, 2021
@roblourens roblourens added this to the August 2021 milestone Aug 21, 2021
roblourens added a commit that referenced this issue Aug 21, 2021
Add a "verbose" logging level
Fix #6468
roblourens added a commit that referenced this issue Aug 21, 2021
Add a "verbose" logging level
Fix #6468
roblourens added a commit that referenced this issue Aug 23, 2021
Add a "verbose" logging level
Fix #6468
roblourens added a commit that referenced this issue Aug 23, 2021
* Log debug adapter traffic
Add a "verbose" logging level
Fix #6468

* Update active notebook editor context keys immediately on start

* Fix some RBL bugs and simplify DAP communication.
- Forward all debug events to client
- Avoid sending messages to the wrong place
- Don't block the configurationDone event on execution

* Don't show "Starting" popup on every RBL

* Dispose global listeners in debug adapter

* Don't delete ipykernel cell file directory. It's not always empty and this spams errors in the console.
joyceerhl pushed a commit that referenced this issue Aug 23, 2021
Add a "verbose" logging level
Fix #6468
joyceerhl pushed a commit that referenced this issue Aug 23, 2021
* Log debug adapter traffic
Add a "verbose" logging level
Fix #6468

* Update active notebook editor context keys immediately on start

* Fix some RBL bugs and simplify DAP communication.
- Forward all debug events to client
- Avoid sending messages to the wrong place
- Don't block the configurationDone event on execution

* Don't show "Starting" popup on every RBL

* Dispose global listeners in debug adapter

* Don't delete ipykernel cell file directory. It's not always empty and this spams errors in the console.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants