-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yellow line highlighting in jupyter notebook unreadable in default dark themes #8697
Comments
Similar. Didn't realize we needed to remove the extra colors that IPython added too. |
This problem would show up in notebooks (not just interactive as #8675 is) |
Hopefully this one can be fixed by remapping the color to a vs code terminal color. |
Thanks, yeah I’m pretty sure I did just update IPython
…On Thu, Jan 13, 2022 at 6:54 PM Ian Huff ***@***.***> wrote:
If you just updated to IPython8 I believe this is the same root cause as
this issue here:
#8675 <#8675>
@rchiodo <https://github.com/rchiodo> This is the same traceback issue,
right?
—
Reply to this email directly, view it on GitHub
<#8697 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZLE7OYVEX5GFSMQWPACV3UV5Q47ANCNFSM5L5BNH6A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I'm just going to fix this at the same time as #8675. We can't handle background colors so just going to remove them from the tracebacks. |
I still seem to have this problem and I'm using all the latest versions as of September 23rd -- do I need to change some configuration? |
The root cause of this problem before was IPython adding ascii color tokens to the output. You could check your IPython version, perhaps they've added new colors since we addressed this. Your best bet would be to open a new issue though. |
Applies To
What happened?
I'm not positive if this is primarily a bug in vscode or something else, but after updating vscode (as well as upgrading a few packages in pip), the yellow highlighted lines in python error tracebacks in jupyter notebooks have become essentially unreadable in the default dark themes...
...and better-but-not-great even in the light themes (though I have always used the dark theme before, so I can't say if the light theme here is better, worse, or same than it was previously)
VS Code Version
Version: 1.63.2 Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3 Date: 2021-12-15T09:37:28.172Z Electron: 13.5.2 Chromium: 91.0.4472.164 Node.js: 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin x64 20.6.0
Jupyter Extension Version
v2021.11.1001550889
Jupyter logs
Coding Language and Runtime Version
Python 3.9.1
Language Extension Version (if applicable)
No response
Anaconda Version (if applicable)
No response
Running Jupyter locally or remotely?
Local
The text was updated successfully, but these errors were encountered: