Turn off string filtering for completions

news/2 Fixes/8893.md

@@ -0,0 +1 @@
+Fix to provide autocomplete inside of quoted strings. This fix also enabled a setting to allow the use of Jedi for completions in a kernel, but should be used with caution. Jedi can hang the kernel preventing exeuction from happening.

package.json

@@ -1985,7 +1985,7 @@
                 },
                 "jupyter.pythonCompletionTriggerCharacters": {
                     "type": "string",
-                    "default": ".%",
+                    "default": ".%'\"",
                     "description": "Characters which trigger auto completion on a python jupyter kernel.",
                     "scope": "machine"
                 },
@@ -2000,6 +2000,12 @@
                     "default": false,
                     "description": "Add PYTHONNOUSERSITE to kernels before starting. This prevents global/user site-packages from being used in the PYTHONPATH of the kernel.",
                     "scope": "machine"
+                },
+                "jupyter.enableExtendedKernelCompletions": {
+                    "type": "boolean",
+                    "default": false,
+                    "markdownDescription": "Enables Jedi support for extended IntelliSense completions in running Jupyter kernels (see this [setting](https://ipython.readthedocs.io/en/stable/config/options/terminal.html?highlight=use_jedi#configtrait-Completer.use_jedi)). This can greatly impact notebook cell execution performance. Use with caution.",
+                    "scope": "machine"
                 }
             }
         },

src/intellisense/pythonKernelCompletionProvider.ts

@@ -281,11 +281,6 @@ export function filterCompletions(
         allowStringFilter &&
         (triggerCharacter == "'" || triggerCharacter == '"' || positionInsideString(line, position));
 
-    // If inside of a string, filter out everything except file names
-    if (insideString) {
-        result = result.filter((r) => r.itemText.includes('.') || r.itemText.endsWith('/'));
-    }
-
     traceInfoIfCI(`Jupyter completions filtering applied: ${insideString} on ${line}`);
 
     // Update magics to have a much lower sort order than other strings.

src/kernels/kernel.base.ts

@@ -623,7 +623,9 @@ export abstract class BaseKernel implements IKernel {
             if (file) {
                 result.push(`__vsc_ipynb_file__ = "${file.replace(/\\/g, '\\\\')}"`);
             }
-            result.push(CodeSnippets.DisableJedi);
+            if (!this.configService.getSettings(undefined).enableExtendedKernelCompletions) {
+                result.push(CodeSnippets.DisableJedi);
+            }
 
             // For Python notebook initialize matplotlib
             // Wrap this startup code in try except as it might fail

src/platform/common/configSettings.ts

@@ -101,6 +101,7 @@ export class JupyterSettings implements IWatchableJupyterSettings {
     public logKernelOutputSeparately: boolean = false;
     public poetryPath: string = '';
     public excludeUserSitePackages: boolean = false;
+    public enableExtendedKernelCompletions: boolean = false;
 
     public variableTooltipFields: IVariableTooltipFields = {
         python: {

src/platform/common/types.ts

@@ -115,6 +115,7 @@ export interface IJupyterSettings {
     readonly logKernelOutputSeparately: boolean;
     readonly poetryPath: string;
     readonly excludeUserSitePackages: boolean;
+    readonly enableExtendedKernelCompletions: boolean;
 }
 
 export interface IVariableTooltipFields {

src/test/datascience/interactiveWindow.vscode.test.ts

@@ -50,7 +50,7 @@ import { EXTENSION_ROOT_DIR } from '../../platform/constants.node';
 type DebuggerType = 'VSCodePythonDebugger' | 'JupyterProtocolDebugger';
 const debuggerTypes: DebuggerType[] = ['JupyterProtocolDebugger', 'VSCodePythonDebugger'];
 debuggerTypes.forEach((debuggerType) => {
-    suite.only(`Interactive window debugger using ${debuggerType}`, async function () {
+    suite(`Interactive window debugger using ${debuggerType}`, async function () {
         this.timeout(120_000);
         let api: IExtensionTestApi;
         const disposables: IDisposable[] = [];