Web variable viewer #10154
Merged
Web variable viewer #10154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
reviewed
May 26, 2022
rchiodo
approved these changes
May 26, 2022
sadasant
commented
May 26, 2022
| // Allow js and js.map files to be loaded by webpack in the webview. | ||
| testFiles | ||
| .filter((f) => f.fsPath.toLowerCase().endsWith('.js') || f.fsPath.toLowerCase().endsWith('.js.map')) | ||
| .forEach((f) => this.webviewHost?.webview!.asWebviewUri(f)); |
There was a problem hiding this comment.
testFiles fails to be read in the browser. vscfs.readDirectory throws saying that this.options.rootPath (the webview-side/viewers directory) isn't a directory.
It could be something with the path, but this doesn't seem needed.
(I've asked @rchiodo , but please let me know if I misinterpreted anything)
sadasant
commented
May 26, 2022
| const proxy = workspaceService.getConfiguration('http').get('proxy', ''); | ||
| if (proxy) { | ||
| this.requestOptions = { headers: { proxy: workspaceService.getConfiguration('http').get('proxy', '') } }; | ||
| } |
There was a problem hiding this comment.
By default, the code here used to mean that requestOptions was { headers: { proxy: '' } } which makes request fail in the browser.
Codecov Report
@@ Coverage Diff @@
## main #10154 +/- ##
=====================================
- Coverage 60% 60% -1%
=====================================
Files 203 203
Lines 9236 9241 +5
Branches 1490 1492 +2
=====================================
- Hits 5632 5628 -4
- Misses 3129 3136 +7
- Partials 475 477 +2
|
amunger
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's working!
Feedback always appreciated 🙏
Fixes #9664