Results for comm messages sent from widgets should get handled by the same cell (part 3) #10157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
changed the title
rchiodo
approved these changes
May 27, 2022
DonJayamanne
force-pushed
the
kernelConnectionWrapperStep2
branch
2 times, most recently
from
a537cfd to
a2ea698
Compare
DonJayamanne
force-pushed
the
kernelConnectionWrapperStep3
branch
from
42d3918 to
1ba0e03
Compare
DonJayamanne
force-pushed
the
kernelConnectionWrapperStep3
branch
3 times, most recently
from
5d6f3f0 to
9027290
Compare
… same cell (part 3)
DonJayamanne
force-pushed
the
kernelConnectionWrapperStep3
branch
from
9027290 to
b33c2b2
Compare
DonJayamanne
force-pushed
the
kernelConnectionWrapperStep2
branch
from
a2ea698 to
749d2f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be reviewed after https://github.com/microsoft/vscode-jupyter/pull/10155/files
Fixes #9503
Once the necessary refactoring has been done, the fix is pretty simple.