getActiveInteractiveWindow to getActiveOrAssociatedInteractiveWindow #10160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #10153
As @DonJayamanne pointed out in #10153 (comment),
IInteractiveWindowProvider
already hasactiveWindow
getter, which gives you the currently active/focused interactive window instance in VS Code. The newly introducedgetActiveInteractiveWindow
is ambiguous as it actually does two things:activeWindow
getteractiveWindow
but there is an active text editor, find its associated interactive windowThus I think it's better to rename this function to
getActiveOrAssociatedInteractiveWindow
to reflect its purpose better.package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).