Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepping the release branch #10306

Merged
merged 4 commits into from
Jun 3, 2022

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Jun 3, 2022

No description provided.

@rchiodo rchiodo requested a review from a team as a code owner June 3, 2022 20:52
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022

Codecov Report

Merging #10306 (4bd322d) into release/release-2022.05.100 (53f3048) will increase coverage by 0%.
The diff coverage is n/a.

❗ Current head 4bd322d differs from pull request most recent head 30c8a37. Consider uploading reports for the commit 30c8a37 to get more accurate results

@@                     Coverage Diff                      @@
##           release/release-2022.05.100   #10306   +/-   ##
============================================================
  Coverage                           64%      64%           
============================================================
  Files                              204      204           
  Lines                             9295     9295           
  Branches                          1505     1505           
============================================================
+ Hits                              5966     5969    +3     
+ Misses                            2857     2853    -4     
- Partials                           472      473    +1     
Impacted Files Coverage Δ
src/platform/errors/errorHandler.ts 64% <0%> (+1%) ⬆️

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
([#9984](https://github.com/Microsoft/vscode-jupyter/issues/9984))
1. Add editor context key support into the web extension.
([#9990](https://github.com/Microsoft/vscode-jupyter/issues/9990))
1. Fix problem with PYTHONNOUSERSITE being set even when not desired. There's a setting now that will set this environment variable on kernel launch if it's needed: 'jupyter.excludeUserSitePackages'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Fix problem with PYTHONNOUSERSITE being set even when not desired. There's a setting now that will set this environment variable on kernel launch if it's needed: 'jupyter.excludeUserSitePackages'.
1. Fix problem with `PYTHONNOUSERSITE` being set even when not desired. There's a setting now that will set this environment variable on kernel launch if it's needed: `jupyter.excludeUserSitePackages`.

how about these quotes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rchiodo rchiodo merged commit e087816 into release/release-2022.05.100 Jun 3, 2022
@rchiodo rchiodo deleted the rchiodo/update_changelog branch June 3, 2022 21:49
rchiodo added a commit that referenced this pull request Jun 3, 2022
* Update changelog

* Update engine number

* Review feedback

* Remove unclosed issue
rchiodo added a commit that referenced this pull request Jun 3, 2022
* Prepping the release branch (#10306)

* Update changelog

* Update engine number

* Review feedback

* Remove unclosed issue

* Update to next version

* Update with changes for variable viewer

* Put back correct engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants